[Intel-gfx] [PATCH i-g-t] tests/gem_render_linear_blits: split into two subtests

Chris Wilson chris at chris-wilson.co.uk
Mon Feb 23 03:46:51 PST 2015


On Mon, Feb 23, 2015 at 09:25:22AM +0000, Gore, Tim wrote:
> > > +	igt_subtest("apperture-thrash") {
> > > +		if (argc > 1)
> > > +			count = atoi(argv[1]);
> > 
> > With automated testing we want to perform the same test over and over
> > again. If it is called aperture-thrash, let's make sure we do!
> > 
> > If anyone ever wants to manually run this with varying amounts of
> > objects: first they should consider enhancing the test to capture the scenario
> > of concern, then secondly add the manual option.
> > 
> 
> Hi Chris,  are you suggesting that I remove the command line option for count?

Yes, I don't think it makes much sense to keep it. Whilst you are here,
could you add a third subtest for "swap-thrash" (the check is
intel_require_memory(CHECK_RAM | CHECK_SWAP), and I'll let you work out
how to compute count :)
-Chris
> 

-- 
Chris Wilson, Intel Open Source Technology Centre


More information about the Intel-gfx mailing list