[Intel-gfx] [PATCH i-g-t 00/12] Testing the Y tiled display

[Daniel Vetter]

On Mon, Feb 23, 2015 at 03:57:43PM +0000, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
> 
> Starting with Skylake the display engine can scan out Y tiled objects. (Both
> legacy Y tiled, and the new Yf format.)
> 
> This series takes the original work by Damien Lespiau and converts it to use the
> new frame buffer modifiers instead of object set/get tiling. Some patches needed
> to be dropped, some added and some refactored.
> 
> v2: Refactored for fb modifier changes.
> 
> Damien Lespiau (7):
>   lib: Extract igt_buf_write_to_png() from gem_render_copy
>   lib/skl: Add gen9 specific igt_blitter_fast_copy()
>   lib: Don't give a struct igt_buf * to fast_copy_pitch()
>   lib: Split two helpers to build fast copy's dword0 and dword1
>   lib: Provide a raw version of the gen9 fast copy blits
>   lib: Allow the creation of Ys/Yf tiled FBs
>   testdisplay/skl: Add command line options for Yb/Yf tiled fbs
> 
> Tvrtko Ursulin (5):
>   tests/kms_addfb: Add support for fb modifiers
>   tests/kms_addfb: Y tiled testcases
>   tiling: Convert framebuffer helpers to use fb modifiers
>   lib: Add support for new extension to the ADDFB2 ioctl.
>   lib/igt_fb: Use new ADDFB2 extension for new tiling modes

Test coverage looks good to me overall, just two minor things:
- functional automated test (replied to the testdisplay patch)
- catching invalid modifiers and making sure y/yf tiling is reject
  unconditionally on pre-gen9 seem to be missing too.

Detail checking that we have full coverage is imo for the in-depth review.

Kernel patches also look good, just a few minor comments.

Cheers, Daniel
> 
>  lib/igt_fb.c                | 163 +++++++++++++++++++++----
>  lib/igt_fb.h                |  10 +-
>  lib/igt_kms.h               |   1 +
>  lib/intel_batchbuffer.c     | 281 ++++++++++++++++++++++++++++++++++++++++++++
>  lib/intel_batchbuffer.h     |  37 ++++++
>  lib/intel_reg.h             |  18 +++
>  lib/ioctl_wrappers.c        |  49 ++++++++
>  lib/ioctl_wrappers.h        |  41 +++++++
>  tests/gem_render_copy.c     |  24 +---
>  tests/kms_3d.c              |   2 +-
>  tests/kms_addfb.c           | 135 ++++++++++++++++++++-
>  tests/kms_cursor_crc.c      |   8 +-
>  tests/kms_fbc_crc.c         |   4 +-
>  tests/kms_fence_pin_leak.c  |   4 +-
>  tests/kms_flip.c            |   6 +-
>  tests/kms_flip_event_leak.c |   4 +-
>  tests/kms_flip_tiling.c     |   7 +-
>  tests/kms_mmio_vs_cs_flip.c |  12 +-
>  tests/kms_pipe_crc_basic.c  |   2 +-
>  tests/kms_plane.c           |   8 +-
>  tests/kms_psr_sink_crc.c    |   8 +-
>  tests/kms_pwrite_crc.c      |   4 +-
>  tests/kms_render.c          |   8 +-
>  tests/kms_rotation_crc.c    |   4 +-
>  tests/kms_setmode.c         |   2 +-
>  tests/kms_sink_crc_basic.c  |   6 +-
>  tests/kms_universal_plane.c |  18 +--
>  tests/pm_lpsp.c             |   2 +-
>  tests/pm_rpm.c              |  26 ++--
>  tests/testdisplay.c         |  20 +++-
>  30 files changed, 795 insertions(+), 119 deletions(-)
> 
> -- 
> 2.3.0
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch