[Intel-gfx] [PATCH] drm/i915: Removed the read of RP_STATE_CAP from sysfs/debugfs functions

Chris Wilson chris at chris-wilson.co.uk
Thu Feb 26 00:04:28 PST 2015


On Thu, Feb 26, 2015 at 01:29:09PM +0530, akash.goel at intel.com wrote:
> From: Akash Goel <akash.goel at intel.com>
> 
> The frequency values(Rp0, Rp1, Rpn) reported by RP_STATE_CAP register
> are stored, initially by the Driver, inside the dev_priv->rps structure.
> Since these values are expected to remain same throughout, there is no real
> need to read this register, on dynamic basis, from debugfs/sysfs functions
> and the values can be instead retrieved from the dev_priv->rps structure
> when needed.

Inside debugfs, you want both as we want to compare what the hardware
thinks and what we believe it should be. Everywhere else we should
indeed be trusting our bookkeeping.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


More information about the Intel-gfx mailing list