[Intel-gfx] [PATCH v2] drm/i915: Removed the read of RP_STATE_CAP from sysfs/debugfs functions

Daniel Vetter daniel at ffwll.ch
Thu Feb 26 05:29:40 PST 2015


On Thu, Feb 26, 2015 at 10:38:28AM +0000, Chris Wilson wrote:
> On Thu, Feb 26, 2015 at 04:09:47PM +0530, akash.goel at intel.com wrote:
> > From: Akash Goel <akash.goel at intel.com>
> > 
> > The frequency values(Rp0, Rp1, Rpn) reported by RP_STATE_CAP register
> > are stored, initially by the Driver, inside the dev_priv->rps structure.
> > Since these values are expected to remain same throughout, there is no real
> > need to read this register, on dynamic basis, from certain debugfs/sysfs
> > functions and the values can be instead retrieved from the dev_priv->rps
> > structure when needed.
> > For the i915_frequency_info debugfs interface, the frequency values from the
> > RP_STATE_CAP register only should be used, to indicate the actual Hw state,
> > since it is principally used for the debugging purpose.
> > 
> > v2: Reverted the changes in i915_frequency_info function, to continue report
> >     back the frequency values, as per the actual Hw state (Chris)
> > 
> > Signed-off-by: Akash Goel <akash.goel at intel.com>
> Nice improvement,
> Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>

Queued for -next, thanks for the patch.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch


More information about the Intel-gfx mailing list