[Intel-gfx] [PATCH v4 01/24] drm/i915/trace: Fix offsets for 64b

[Mika Kuoppala]

Michel Thierry <michel.thierry at intel.com> writes:

> From: Ben Widawsky <benjamin.widawsky at intel.com>
>
> Signed-off-by: Ben Widawsky <ben at bwidawsk.net>
> Signed-off-by: Michel Thierry <michel.thierry at intel.com>
> ---
>  drivers/gpu/drm/i915/i915_trace.h | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_trace.h b/drivers/gpu/drm/i915/i915_trace.h
> index 6058a01..f004d3d 100644
> --- a/drivers/gpu/drm/i915/i915_trace.h
> +++ b/drivers/gpu/drm/i915/i915_trace.h
> @@ -115,7 +115,7 @@ TRACE_EVENT(i915_vma_bind,
>  	    TP_STRUCT__entry(
>  			     __field(struct drm_i915_gem_object *, obj)
>  			     __field(struct i915_address_space *, vm)
> -			     __field(u32, offset)
> +			     __field(u64, offset)
>  			     __field(u32, size)
>  			     __field(unsigned, flags)

We seem to use uint64_t for flags in caller. Not that we are using
past a few currently so we good for now.

Reviewed-by: Mika Kuoppala <mika.kuoppala at intel.com>

>  			     ),
> @@ -128,7 +128,7 @@ TRACE_EVENT(i915_vma_bind,
>  			   __entry->flags = flags;
>  			   ),
>  
> -	    TP_printk("obj=%p, offset=%08x size=%x%s vm=%p",
> +	    TP_printk("obj=%p, offset=%016llx size=%x%s vm=%p",
>  		      __entry->obj, __entry->offset, __entry->size,
>  		      __entry->flags & PIN_MAPPABLE ? ", mappable" : "",
>  		      __entry->vm)
> @@ -141,7 +141,7 @@ TRACE_EVENT(i915_vma_unbind,
>  	    TP_STRUCT__entry(
>  			     __field(struct drm_i915_gem_object *, obj)
>  			     __field(struct i915_address_space *, vm)
> -			     __field(u32, offset)
> +			     __field(u64, offset)
>  			     __field(u32, size)
>  			     ),
>  
> @@ -152,7 +152,7 @@ TRACE_EVENT(i915_vma_unbind,
>  			   __entry->size = vma->node.size;
>  			   ),
>  
> -	    TP_printk("obj=%p, offset=%08x size=%x vm=%p",
> +	    TP_printk("obj=%p, offset=%016llx size=%x vm=%p",
>  		      __entry->obj, __entry->offset, __entry->size, __entry->vm)
>  );
>  
> -- 
> 2.1.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx