[Intel-gfx] [PATCH 1/8] drm/i915: don't increment the FBC threshold at fbc_enable

Daniel Vetter daniel at ffwll.ch
Wed Jul 1 06:52:02 PDT 2015


On Tue, Jun 30, 2015 at 03:22:51PM +0100, Chris Wilson wrote:
> On Tue, Jun 30, 2015 at 10:53:05AM -0300, Paulo Zanoni wrote:
> > From: Paulo Zanoni <paulo.r.zanoni at intel.com>
> > 
> > We first set the threshold value when we're allocating the CFB, and
> > then later at {ilk,gen7}_fbc_enable() we increment it in case we're
> > using 16bpp. While that is correct, it is dangerous: if we rework the
> > code a little bit in a way that allows us to call intel_fbc_enable()
> > without necessarily calling i915_gem_stolen_setup_compression() first,
> > we might end up incrementing threshold more than once. To prevent
> > that, increment a temporary variable instead.
> > 
> > v2: Rebase.
> > 
> > Signed-off-by: Paulo Zanoni <paulo.r.zanoni at intel.com>
> 
> Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>

Queued for -next, thanks for the patch.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch


More information about the Intel-gfx mailing list