[Intel-gfx] [PATCH v2] drm/i915: Also perform gpu reset under execlist mode.

Chris Wilson chris at chris-wilson.co.uk
Fri Jul 3 02:01:56 PDT 2015


On Sat, Jul 04, 2015 at 12:27:34AM +0800, bing.niu at intel.com wrote:
> From: "Niu,Bing" <bing.niu at intel.com>
> 
> It is found that i915 will not reset gpu under execlist mode when
> unload module. that will lead to some issues when unload/load module
> with different submission mode. e.g. from execlist mode to ring
> buffer mode via loading/unloading i915. Because HW is not in a reset
> state and registers are not clean under such condition.
> 
> Signed-off-by: Niu,Bing <bing.niu at intel.com>
Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>

I think we may end up doing the reset unconditionally in
i915_driver_unload() because this argument holds for almost everything
we setup. It's a bigger risk because of doing the gpu-reset on more
machines, but module-unloading is a "developer feature"!

The only issue is making sure that the reset is ordered appropriately.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


More information about the Intel-gfx mailing list