[Intel-gfx] [PATCH v2] drm/i915: Per-DDI I_boost override

[Damien Lespiau]

On Fri, Jul 03, 2015 at 06:37:59PM +0300, Antti Koskipää wrote:
> >> @@ -239,8 +243,13 @@ struct common_child_dev_config {
> >>         u8 not_common2[2];
> >>         u8 ddc_pin;
> >>         u16 edid_ptr;
> >> +       u8 obsolete;
> >> +       u8 flags_1;
> >> +       u8 not_common3[13];
> >> +       u8 iboost_level;
> > 
> > In the old VBT spec I have, each child_dev_config is supposed to have
> > only 33 bytes. But in this patch you're increasing it to 38. I believe
> > this is what's causing the errors I see when I boot my BDW.
> > 
> > Are you sure they increased the VBT's ChildDevInfo to more than 33
> > bytes? I don't have access to your VBT spec right now, so I can't do a
> > proper review or a suggestion on how to fix the problem.
> 
> The VBT spec I coded for does increase the size. You need to look at
> version >= 196 of the spec.

But then, what Ville said?

        /* judge whether the size of child device meets the requirements.
         * If the child device size obtained from general definition block
         * is different with sizeof(struct child_device_config), skip the
         * parsing of sdvo device info
         */
        if (p_defs->child_dev_size != sizeof(*p_child)) {
                /* different child dev size . Ignore it */
                DRM_DEBUG_KMS("different child size is found. Invalid.\n");
                return;
        }

with const union child_device_config *p_child;

-- 
Damien