[Intel-gfx] [PATCH 2/2] drm/i915: Use expcitly fixed type in compat32 structs

Chris Wilson chris at chris-wilson.co.uk
Tue Jul 14 02:19:10 PDT 2015


On Tue, Jul 14, 2015 at 10:59:31AM +0200, Daniel Vetter wrote:
> I was confused shortly whether the compat was needed for the int,
> until I noticed the pointer in the original.
> 
> Also remove typedef.
> 
> Signed-off-by: Daniel Vetter <daniel.vetter at intel.com>

Oh, why an int? But you should improve the uapi definition as well. And
add a (short) paragraph before it to explain exactly why we should never
ever do this again.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


More information about the Intel-gfx mailing list