[Intel-gfx] [PATCH] drm/i915: Use expcitly fixed type in compat32 structs

Chris Wilson chris at chris-wilson.co.uk
Tue Jul 14 09:11:38 PDT 2015


On Tue, Jul 14, 2015 at 06:07:30PM +0200, Daniel Vetter wrote:
> I was confused shortly whether the compat was needed for the int,
> until I noticed the pointer in the original.
> 
> Also remove typedef.
> 
> v2: Review from Chris.
> - Add comments.
> - Also change the int param in the original structure.
> 
> Cc: Chris Wilson <chris at chris-wilson.co.uk>
> Signed-off-by: Daniel Vetter <daniel.vetter at intel.com>

I think there is much more value in documenting every mistake we make in
the uabi than there is the fixes themselves, so the comments are much
appreciated.

Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


More information about the Intel-gfx mailing list