[Intel-gfx] [PATCH] Revert "drm/i915: Declare the swizzling unknown for L-shaped configurations"

Chris Wilson chris at chris-wilson.co.uk
Tue Jul 14 09:15:11 PDT 2015


On Tue, Jul 14, 2015 at 12:31:21PM +0200, Daniel Vetter wrote:
> This reverts commit 19ee835cdb0b5a8eb11a68f25a51b8039d564488.
> 
> It breaks existing old userspace which doesn't handle UNKNOWN
> swizzling correct. Yes UNKNOWN was a thing back in 2009 and probably
> still is on some other platforms, but it still pretty clearly broke
> the testers machine. If we want this we need to extend the ioctl with
> new paramters that only new userspace looks at.
> 
> Cc: Harald Arnesen <harald at skogtun.org>
> Cc: Chris Wilson <chris at chris-wilson.co.uk>
> Reported-by: Harald Arnesen <harald at skogtun.org>
> Cc: stable at vger.kernel.org
> Signed-off-by: Daniel Vetter <daniel.vetter at intel.com>

I am annoyed, but under the rules we have to revert this because
userspace (me) fscked up.

Acked-by: Chris Wilson <chris at chris-wilson.co.uk>

But v1 should work in 99.9% of cases.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


More information about the Intel-gfx mailing list