[Intel-gfx] [PATCH 4/5] drm/i915: Remove wait_for_pending_flips from disable_noatomic.

Chris Wilson chris at chris-wilson.co.uk
Tue Jul 21 04:35:58 PDT 2015


On Thu, Jul 16, 2015 at 02:57:50PM +0200, Maarten Lankhorst wrote:
> Now that intel_display_suspend is atomic it's safe to remove
> wait_for_pending_flips from intel_crtc_disable_noatomic. It
> will only be used during hw load or resume, in which case there
> will be no pending flips anyway.

A WARN_ON(pending_flip) then? (Actually we should start doing
DRM_ERROR_ON I guess that would make a lot of complaints go away, and
also a lot of genuine bug reports) Or do we have warning coverage
elsewhere along the CRTC change path?
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


More information about the Intel-gfx mailing list