[Intel-gfx] [PATCH 01/18] drm/i915/bxt: Path added of dmc firmware ver1 for BXT

Sunil Kamath sunil.kamath at intel.com
Sun Jul 26 21:51:16 PDT 2015


On Sunday 26 July 2015 12:30 AM, Animesh Manna wrote:
> Cc: Damien Lespiau <damien.lespiau at intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi at intel.com>
> Cc: Sunil Kamath <sunil.kamath at intel.com>
> Signed-off-by: Animesh Manna <animesh.manna at intel.com>
> ---

Please update the commit message header relevant details.
even one liner is sufficient.

Minor thing to take care.

Reviewed-by: A.Sunil Kamath <sunil.kamath at intel.com>

- Sunil
>   drivers/gpu/drm/i915/intel_csr.c | 4 ++++
>   1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_csr.c b/drivers/gpu/drm/i915/intel_csr.c
> index 6d8a7bf..1866426 100644
> --- a/drivers/gpu/drm/i915/intel_csr.c
> +++ b/drivers/gpu/drm/i915/intel_csr.c
> @@ -42,8 +42,10 @@
>    */
>   
>   #define I915_CSR_SKL "i915/skl_dmc_ver1.bin"
> +#define I915_CSR_BXT "i915/bxt_dmc_ver1.bin"
>   
>   MODULE_FIRMWARE(I915_CSR_SKL);
> +MODULE_FIRMWARE(I915_CSR_BXT);
>   
>   /*
>   * SKL CSR registers for DC5 and DC6
> @@ -417,6 +419,8 @@ void intel_csr_ucode_init(struct drm_device *dev)
>   
>   	if (IS_SKYLAKE(dev))
>   		csr->fw_path = I915_CSR_SKL;
> +	else if (IS_BROXTON(dev))
> +		csr->fw_path = I915_CSR_BXT;
>   	else {
>   		DRM_ERROR("Unexpected: no known CSR firmware for platform\n");
>   		intel_csr_load_status_set(dev_priv, FW_FAILED);



More information about the Intel-gfx mailing list