[Intel-gfx] Error in inner loop in validate_cmds_sorted / out of bounds issue

Hanno Böck hanno at hboeck.de
Tue Jul 28 11:14:19 PDT 2015


Hi,

On Tue, 28 Jul 2015 10:14:51 +0200
Daniel Vetter <daniel at ffwll.ch> wrote:

> > Indeed, nice catch. Could you please read
> > Documentation/SubmittingPatches and apply your Signed-off-by and
> > then we can accept this patch under your authorship.
> > 
> > Preferrably this is two patches, (a) fix the tables, (b) fix the
> > validator. That way we can delay enabling the validator if we need
> > to fix the tables for others.

I think I have checked all tables, not just the ones used on my gpu,
they should be fine. But I've splittet the patch.

> Also can you please add signed-off-by lines to your patch when
> resubmitting? See Documentation/SubmittingPatches for all the details.

The patch already had a "Signed-off-by" line.

The checkpatch script complains that it doesn't like the formatting of
the CMD command. However I won't change that in this patch, as this is
how the whole file is formatted. If this is wanted I can submit a patch
changing the formatting afterwards, but I think this is an unrelated
change.

Please apply.

-- 
Hanno Böck
http://hboeck.de/

mail/jabber: hanno at hboeck.de
GPG: BBB51E42
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 01-i915-fix-cmd-order.patch
Type: text/x-patch
Size: 976 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20150728/95b06d7b/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 02-i915-fix-cmd-check-loop.patch
Type: text/x-patch
Size: 587 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20150728/95b06d7b/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20150728/95b06d7b/attachment-0001.sig>


More information about the Intel-gfx mailing list