[Intel-gfx] [PATCH] Fix resume from suspend to RAM on IBM X30 (take two)

Daniel Vetter daniel at ffwll.ch
Mon Jun 15 03:21:49 PDT 2015


On Mon, Jun 01, 2015 at 10:25:10AM +0200, Thomas Richter wrote:
> Hi Daniel, hi Ville,
> 
> as suggested, I again checked against the latest drm-intel-nightly
> branch and indeed, the patch as originally submitted does not apply
> there. So I recompiled the patch again (see attachment) which works now
> correctly with the latest branch.
> 
> As suggested, I made a couple of additional changes:
> 
> * No longer forces bit-banging on. As Daniel observed, this is not
> really required, and I checked that, indeed, it is not.
> 
> * Ville made a comment a while ago that we should not enable the
> extended panel-scaling of the IVCH, so I removed it. In fact, as the X30
> bios does not restore registers during resume, it also fails to restore
> the (undocumented) values of the advanced interpolation polynomials and
> as such degrades the image quality when resuming from suspend.
> 
> Other than that, this patch has been successfully tested both on an IBM
> X30 and on an IBM R31 ThinkPad, both making use of the IVCH DVO chip.

Yup this one applies cleanly now. Queued for -next, thanks for the patch.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch


More information about the Intel-gfx mailing list