[Intel-gfx] [PATCH i-g-t] tests/kms_fbc_crc: Don't force fbc on old platforms

[Chris Wilson]

On Mon, Jun 15, 2015 at 05:14:17PM +0200, Daniel Vetter wrote:
> It's simply a bit too scary on pre-gen6 and imo not worth the bother
> really until someone starts to implement all the hacks an w/a required
> on these platforms. On later platforms the issues are just with
> correctness and performance hence no risk for hanging machines.
> 
> Cc: Paulo Zanoni <przanoni at gmail.com>
> Signed-off-by: Daniel Vetter <daniel.vetter at intel.com>
> ---
>  tests/kms_fbc_crc.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/kms_fbc_crc.c b/tests/kms_fbc_crc.c
> index d9642243465c..f2a86a690767 100644
> --- a/tests/kms_fbc_crc.c
> +++ b/tests/kms_fbc_crc.c
> @@ -562,7 +562,8 @@ igt_main
>  		igt_require_f(!strstr(buf, "unsupported on this chipset"),
>  			      "FBC not supported\n");
>  
> -		igt_set_module_param_int("enable_fbc", 1);
> +		if (intel_gen(data.devid) >= 6)
> +			igt_set_module_param_int("enable_fbc", 1);

That reminds me, using these module params causes lots of "dangerous
module option" spew. Which I think is justified! However, the
alternatives would be either a SETPARAM ioctl or debugfs.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre