[Intel-gfx] [PATCH] drm/i915: Fix up KMS Kconfig removal patch

Chris Wilson chris at chris-wilson.co.uk
Tue Jun 23 05:16:20 PDT 2015


On Tue, Jun 23, 2015 at 02:04:04PM +0200, Daniel Vetter wrote:
> The module pciid list got lost, but somehow most distros seem to
> force-load drm drivers early and no one noticed for a while.
> 
> Bug introduced in
> 
> commit fd930478fb797e4cbaa799d9ddd970e9a1fa1b4a
> Author: Chris Wilson <chris at chris-wilson.co.uk>
> Date:   Fri Jun 19 20:27:27 2015 +0100
> 
>     drm/i915: Remove KMS Kconfig option
> 
> Reported-by: Tvrtko Ursulin <tvrtko.ursulin at linux.intel.com>
> Cc: Tvrtko Ursulin <tvrtko.ursulin at linux.intel.com>
> Cc: Damien Lespiau <damien.lespiau at intel.com>
> Cc: Chris Wilson <chris at chris-wilson.co.uk>
> Signed-off-by: Daniel Vetter <daniel.vetter at intel.com>
> ---
>  drivers/gpu/drm/i915/i915_drv.c    | 2 --
>  drivers/gpu/drm/i915/i915_params.c | 2 +-
>  2 files changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
> index c69f19271e27..b12a8218e35e 100644
> --- a/drivers/gpu/drm/i915/i915_drv.c
> +++ b/drivers/gpu/drm/i915/i915_drv.c
> @@ -440,9 +440,7 @@ static const struct pci_device_id pciidlist[] = {		/* aka */
>  	{0, 0, 0}
>  };
>  
> -#if defined(CONFIG_DRM_I915_KMS)
>  MODULE_DEVICE_TABLE(pci, pciidlist);
> -#endif

We suggested putting this at the bottom with the other MODULE_()
descriptors.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


More information about the Intel-gfx mailing list