[Intel-gfx] [PATCH 4/9] external/drm: Validate pointer before using

Praveen Paneri praveen.paneri at intel.com
Thu Mar 5 21:45:09 PST 2015


Move the dereferencing below the check for valid ctx pointer.

Signed-off-by: Praveen Paneri <praveen.paneri at intel.com>
---
 intel/intel_decode.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/intel/intel_decode.c b/intel/intel_decode.c
index 2667a7c..5a4fc4a 100644
--- a/intel/intel_decode.c
+++ b/intel/intel_decode.c
@@ -3894,12 +3894,14 @@ drm_intel_decode(struct drm_intel_decode *ctx)
 	int ret;
 	unsigned int index = 0;
 	uint32_t devid;
-	int size = ctx->base_count * 4;
+	int size;
 	void *temp;
 
 	if (!ctx)
 		return;
 
+	size = ctx->base_count * 4;
+
 	/* Put a scratch page full of obviously undefined data after
 	 * the batchbuffer.  This lets us avoid a bunch of length
 	 * checking in statically sized packets.
-- 
1.9.1



More information about the Intel-gfx mailing list