[Intel-gfx] [PATCH 3/5] drm/i915: Track GEN6 page table usage

Daniel Vetter daniel at ffwll.ch
Thu Mar 19 09:08:42 PDT 2015


On Mon, Mar 16, 2015 at 04:00:56PM +0000, Michel Thierry wrote:
> +	BUG_ON(length == 0);
> +	BUG_ON(offset_in_page(addr|length));

Broken record: I'm not a fan of BUG_ON at all, it's a massive pain if you
hit that in driver load in the initial modeset. Since these are just
consistency checks that won't result in immediate fireworks (afaics,
please correct) I've switched them to a WARN_ON.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch


More information about the Intel-gfx mailing list