[Intel-gfx] [PATCH 7/7] drm/i915: Enable PSR by default.

Daniel Vetter daniel at ffwll.ch
Wed Mar 25 06:53:39 PDT 2015


On Tue, Mar 24, 2015 at 10:05:03PM +0000, chris at chris-wilson.co.uk wrote:
> On Tue, Mar 24, 2015 at 08:55:04PM +0000, Vivi, Rodrigo wrote:
> > On Tue, 2015-03-24 at 10:08 +0000, Chris Wilson wrote:
> > > On Tue, Mar 24, 2015 at 11:03:30AM +0100, Daniel Vetter wrote:
> > > > On Mon, Mar 23, 2015 at 01:20:07PM -0700, Rodrigo Vivi wrote:
> > > > > Hi Daniel,
> > > > > 
> > > > > Is something missing to enable it by default?
> > > > 
> > > > Patch 1 has a small comment from me and latest version of patch 2 lacks an
> > > > r-b afaict. Hence why I didn't pull in the series yet. But it's also a
> > > > longer discussion, so ca you please resend the entire series with r-b tags
> > > > added to make sure I don't pick up the wrong versions?
> > > 
> > > Do I yet have a method to tell when PSR is active on an output?
> > 
> > Is that pre computed pipe_config->psr_enabled enough or you mean the
> > immediate psr.active also exposed there on pipe_config?
> 
> I want a property exposed to userspace. Having a tristate that says
> unsupported, disabled, active would be most useful.

Imo we should get the current behind-the-scenes psr support working
correctly first. Later on we can add userspace abi to expose this to
compositors, but that should be a separate step.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch


More information about the Intel-gfx mailing list