[Intel-gfx] [PATCH] drm/i915: kill i915.powersave

Daniel Vetter daniel at ffwll.ch
Thu Mar 26 05:26:53 PDT 2015


On Thu, Mar 26, 2015 at 11:31:35AM +0000, Tvrtko Ursulin wrote:
> 
> On 03/25/2015 01:45 PM, Daniel Vetter wrote:
> >On Tue, Mar 24, 2015 at 08:50:34PM +0000, Chris Wilson wrote:
> >>On Tue, Mar 24, 2015 at 12:40:09PM -0700, Rodrigo Vivi wrote:
> >>>This flag was being mostly used as a meta flag in some
> >>>cases and not covering other cases.
> >>>
> >>>One of the risks is that it was masking some frontbuffer
> >>>trackings without disabling PSR.
> >>>
> >>>So, better to kill this at once and avoid umbrella parameters.
> >>>
> >>>Signed-off-by: Rodrigo Vivi <rodrigo.vivi at intel.com>
> >>
> >>Agreed. Its purpose was never entirely clear and its value in debugging
> >>was the same as using an elephant gun to shot at a gnat.
> >>
> >>Acked-by: Chris Wilson <chris at chris-wilson.co.uk>
> >
> >Queued for -next, thanks for the patch.
> 
> There is an unused out label after this patch which causes a compiler
> warning. Would have sent a patch but I think you sometimes intervene
> manually in the tree for trivial things so did not bother.

Already spotted and squashed away but not yet pushed out.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch


More information about the Intel-gfx mailing list