[Intel-gfx] [PATCH v4] drm/i915: Compare GGTT view structs instead of types

[Daniel Vetter]

On Fri, Mar 27, 2015 at 11:46:24AM +0000, Tvrtko Ursulin wrote:
> 
> Hi,
> 
> On 03/27/2015 11:09 AM, Joonas Lahtinen wrote:
> >To allow for views where the view type is not defined by the view type only,
> >like it is in stereo or rotated 90 degree view, change the semantic to require
> >the whole view structure for comparison when we match a GGTT view.
> >
> >This allows including parameters like offset to be included in the view which
> >is useful for eg. partial views.
> >
> >v3:
> >- Rely on ggtt_view type being 0 for non-GGTT vma's, which equals to
> >   I915_GGTT_VIEW_NORMAL. (Daniel Vetter)
> >- Do not use potentially slower comparison when we only want to know if
> >   something is or is not a normal view.
> >- Rebase on top of rotated view patches. Add rotated view singleton.
> >- If one view is missing in comparison they're equal only if both are missing.
> >
> >v4:
> >- Use comparison helper in obj_to_ggtt_view too. (Tvrtko Ursulin)
> >- Do WARN_ON if one view is NULL. (Tvrtko Ursulin)
> >
> >Cc: Daniel Vetter <daniel at ffwll.ch>
> >Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin at linux.intel.com> (v2)
> >Signed-off-by: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>
> 
> Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>

Queued for -next, thanks for the patch.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch