[Intel-gfx] [PATCH] drm/i915/bxt: Fix eDP panel fitting (v2)

Bob Paauwe bob.j.paauwe at intel.com
Wed Nov 4 13:42:44 PST 2015


On Wed, 4 Nov 2015 09:05:27 -0800
Matt Roper <matthew.d.roper at intel.com> wrote:

> BXT CRTC scaling uses the same gen9 codepaths as SKL; these codepaths
> store panel fitter information in pipe_config->pch_pfit.  However since
> HAS_PCH_SPLIT() is false for BXT we never actually wind up filling in
> this structure (we wind up filling in pipe_config->gmch_pfit instead,
> which is ignored when we go to program the hardware).  Make sure we
> always take the PCH code path on gen9+ platforms.
> 
> v2: Use HAS_GMCH_DISPLAY() to more cleanly describe the platforms that
>     actually want to use GMCH-style panel fitting.  (Ville)
> 
> Cc: Imre Deak <imre.deak at intel.com>
> Cc: Chandra Konduru <chandra.konduru at intel.com>
> Signed-off-by: Matt Roper <matthew.d.roper at intel.com>
> Reviewed-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
> ---
>  drivers/gpu/drm/i915/intel_dp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
> index 1cb1f3f..4655af0 100644
> --- a/drivers/gpu/drm/i915/intel_dp.c
> +++ b/drivers/gpu/drm/i915/intel_dp.c
> @@ -1426,7 +1426,7 @@ intel_dp_compute_config(struct intel_encoder *encoder,
>  				return ret;
>  		}
>  
> -		if (!HAS_PCH_SPLIT(dev))
> +		if (HAS_GMCH_DISPLAY(dev))
>  			intel_gmch_panel_fitting(intel_crtc, pipe_config,
>  						 intel_connector->panel.fitting_mode);
>  		else

Reviewed-by: Bob Paauwe <bob.j.paauwe at intel.com>
Tested-by: Bob Paauwe <bob.j.paauwe at intel.com>

-- 
--
Bob Paauwe                  
Bob.J.Paauwe at intel.com
IOTG / PED Software Organization
Intel Corp.  Folsom, CA
(916) 356-6193    



More information about the Intel-gfx mailing list