[Intel-gfx] [PATCH 02/29] drm/i915: Remove the magic AUX_CTL is at DP + foo tricks

Chris Wilson chris at chris-wilson.co.uk
Fri Nov 6 05:21:41 PST 2015


On Wed, Nov 04, 2015 at 11:19:50PM +0200, ville.syrjala at linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala at linux.intel.com>
> 
> Currently we determine the location of the AUX registers in a confusing
> way. First we assume the PCH registers are used always, but then we
> override it for everything but HSW/BDW to use DP+0x10. Very confusing.
> 
> Let's just make it straightforward and simply add a few functions to
> pick the right AUX_CTL based on the DP port.
> 
> To deal with VLV/CHV we'll include the display_mmio_offset into the
> AUX register defines.
> 
> Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>

Took some time to be happy that is was just code motion,
Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


More information about the Intel-gfx mailing list