[Intel-gfx] [PATCH v3 04/29] drm/i915: Parametrize AUX registers

[Chris Wilson]

On Wed, Nov 04, 2015 at 11:19:52PM +0200, ville.syrjala at linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala at linux.intel.com>
> 
> v2: Keep some MISSING_CASE() stuff (Jani)
>     s/-1/-PIPE_B/ in the register macro
>     Fix typo in patch subject
> v3: Use PORT_B registers for invalid ports in g4x_aux_ctl_reg() (Jani)
> 
> Reviewed-by: Jani Nikula <jani.nikula at intel.com>
> Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
> ---
> diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
> index 62fb95c..2638a60 100644
> --- a/drivers/gpu/drm/i915/intel_dp.c
> +++ b/drivers/gpu/drm/i915/intel_dp.c
> @@ -751,7 +751,7 @@ static uint32_t i9xx_get_aux_send_ctl(struct intel_dp *intel_dp,
>  	else
>  		precharge = 5;
>  
> -	if (IS_BROADWELL(dev) && intel_dp->aux_ch_ctl_reg == DPA_AUX_CH_CTL)
> +	if (IS_BROADWELL(dev) && intel_dp->aux_ch_ctl_reg == DP_AUX_CH_CTL(PORT_A))

Didn't this change to intel_dp->port == PORT_A at some point? Would that
be worth doing earlier?

Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre