[Intel-gfx] [PATCH maintainer-tools] dim: Remove git commit --amend from dim_apply

[Tvrtko Ursulin]

On 13/11/15 12:16, Chris Wilson wrote:
> On Fri, Nov 13, 2015 at 02:05:39PM +0200, Ander Conselvan de Oliveira wrote:
>> Calling git --amend invokes the editor, which will not run if it relies
>> on the terminal for input. So don't do that from dim_apply.
>>
>> Signed-off-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira at intel.com>
>
> Presumable the ammend is there for a good reason and removing it keeps
> the state dirty? So maybe --amend --no-edit?

In either case can also consider "test -t 0" which is like isatty(0).

Regards,

Tvrtko