[Intel-gfx] [PATCH 09/12] drm/i915: Rename intel_context[engine].ringbuf

Chris Wilson chris at chris-wilson.co.uk
Tue Nov 24 07:27:18 PST 2015


On Tue, Nov 24, 2015 at 03:09:42PM +0000, Tvrtko Ursulin wrote:
> 
> On 20/11/15 12:43, Chris Wilson wrote:
> >Perform s/ringbuf/ring/ on the context struct for consistency with the
> >ring/engine split.
> >
> >Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> >---
> >  drivers/gpu/drm/i915/i915_debugfs.c     |  2 +-
> >  drivers/gpu/drm/i915/i915_drv.h         |  4 +-
> >  drivers/gpu/drm/i915/i915_gpu_error.c   |  4 +-
> >  drivers/gpu/drm/i915/intel_lrc.c        | 85 ++++++++++++++++-----------------
> >  drivers/gpu/drm/i915/intel_ringbuffer.c | 12 ++---
> >  5 files changed, 52 insertions(+), 55 deletions(-)
> >
> >diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
> >index 56375c36b381..630717fec688 100644
> >--- a/drivers/gpu/drm/i915/i915_debugfs.c
> >+++ b/drivers/gpu/drm/i915/i915_debugfs.c
> >@@ -1950,7 +1950,7 @@ static int i915_context_status(struct seq_file *m, void *unused)
> >  				struct drm_i915_gem_object *ctx_obj =
> >  					ctx->engine[i].state;
> >  				struct intel_ringbuffer *ringbuf =
> 
> Elsewhere you were renaming this to ring, why not here? I am not
> sure it makes sense (renaming) but it is at least not consistent.

If I change everything at once, the patches get ignored.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


More information about the Intel-gfx mailing list