[Intel-gfx] [PATCH 07/15] drm/i915: Check the timeout passed to i915_wait_request

Tvrtko Ursulin tvrtko.ursulin at linux.intel.com
Mon Nov 30 02:28:13 PST 2015



On 30/11/15 10:22, Chris Wilson wrote:
> On Sun, Nov 29, 2015 at 08:48:05AM +0000, Chris Wilson wrote:
>> We have relied upon the sole caller (wait_ioctl) validating the timeout
>> argument. However, when waiting for multiple requests I forgot to ensure
>> that the timeout was still positive on the later requests. This is more
>> simply done inside __i915_wait_request.
>>
>> Fixes a minor regression introduced in
>>
>> commit b47161858ba13c9c7e03333132230d66e008dd55
>> Author: Chris Wilson <chris at chris-wilson.co.uk>
>> Date:   Mon Apr 27 13:41:17 2015 +0100
>>
>>      drm/i915: Implement inter-engine read-read optimisations
>>
>> where we may end up waiting for an extra jiffie for each active ring
>> after consuming all of the user's timeout.
>
> where we may end up waiting for an extra jiffie (added by
> nsecs_to_jiffie_timeout to guarantee minimum duration) for each active
> ring after consuming all of the user's timeout

Sounds good! R-b given previously can be applied. :)

Regards,

Tvrtko



More information about the Intel-gfx mailing list