[Intel-gfx] [PATCH 2/3] drm/i915: Remove redundant device id from IS_IRONLAKE_M macro

Chris Wilson chris at chris-wilson.co.uk
Mon Mar 18 11:10:43 UTC 2019


Quoting Tvrtko Ursulin (2019-03-18 09:52:57)
> From: Tvrtko Ursulin <tvrtko.ursulin at intel.com>

> Check can use the already defined and separate device info for this

That doesn't read very well:

IS_IRONLAKE_M can use the already defined intel_device_info.is_mobile
for this platform, so remove the instance of Ironlake's mobile device id
from the header file and replace it with an IS_MOBILE check.

> platform in conjunction with the IS_MOBILE check. So remove this instance
> of device id from the header file.
> 
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
> Suggested-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
> Cc: Ville Syrjälä <ville.syrjala at linux.intel.com>
> Cc: Chris Wilson <chris at chris-wilson.co.uk>
Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
-Chris


More information about the Intel-gfx mailing list