[Intel-gfx] [PATCH] drm/i915: Really calculate the cursor ddb based on the highest enabled wm level

Rodrigo Vivi rodrigo.vivi at intel.com
Thu Mar 21 20:20:51 UTC 2019


On Thu, Mar 21, 2019 at 07:51:28PM +0200, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala at linux.intel.com>
> 
> I added the loop but neglected to actually pass the level to the
> function. So we were just looping 8 times calculating the exact
> same thing every time.
> 
> Fixes: df331de3f8aa ("drm/i915: Allocate enough DDB for the cursor")
> Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>

Reviewed-by: Rodrigo Vivi <rodrigo.vivi at intel.com>

> ---
>  drivers/gpu/drm/i915/intel_pm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> index fcd3baff8b65..eaf0793ebf60 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -3953,7 +3953,7 @@ skl_cursor_allocation(const struct intel_crtc_state *crtc_state,
>  	WARN_ON(ret);
>  
>  	for (level = 0; level <= max_level; level++) {
> -		skl_compute_plane_wm(crtc_state, 7, &wp, &wm, &wm);
> +		skl_compute_plane_wm(crtc_state, level, &wp, &wm, &wm);
>  		if (wm.min_ddb_alloc == U16_MAX)
>  			break;
>  
> -- 
> 2.19.2
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx


More information about the Intel-gfx mailing list