[Intel-gfx] [PATCH v2] drm/i915/guc: GuC suspend path cleanup

Chris Wilson chris at chris-wilson.co.uk
Fri Mar 22 09:39:54 UTC 2019


Quoting Chris Wilson (2019-03-22 08:57:35)
> Quoting Sujaritha Sundaresan (2019-03-21 20:38:04)
> > Adding a call to intel_uc_suspend in i915_gem_suspend, which
> > is a common point for the suspend/resume and hibernate paths.
> > This fixes an unbalanced call that causes issues with the CTB
> > register/deregister.
> > 
> > v2: Making the call unconditional (Daniele)
> >         Moving the call to after the GEM_BUG_ON (Chris)
> > 
> > Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio at intel.com>
> > Cc: Chris Wilson <chris at chris-wilson.co.uk>
> > Cc: Michal Wajdeczko <michal.wajdeczko at intel.com>
> > Signed-off-by: Sujaritha Sundaresan <sujaritha.sundaresan at intel.com>
> 
> So I removed this when forcing a reset; then made the forced reset
> conditional...
> Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>

And pushed, thanks for the fixup.
-Chris


More information about the Intel-gfx mailing list