[Intel-gfx] [PATCH] drm/i915: fix i9xx irq enable/disable

Chris Wilson chris at chris-wilson.co.uk
Fri Mar 29 16:33:40 UTC 2019


Quoting Daniele Ceraolo Spurio (2019-03-29 16:20:48)
> 
> 
> On 3/29/19 9:19 AM, Daniele Ceraolo Spurio wrote:
> > Those functions are used on gen4 as well and gen4 does have a non-RCS
> > engine, so remove the BUG_ON and flip back the logic to what it was
> > before the ENGINE_READ/WRITE update
> > 
> > Fixes: baba6e572b38 ("drm/i915: take a reference to uncore in the engine and use it")
> 
> I'm not sure why this hasn't failed on our gen4 machines in CI. Are we 
> now so proactive in polling the HWSP that we just never enable the irqs?

It died on boot and so dropped out of CI. Our mechanism for catching
broken boots let us down here. Lessons learnt.
-Chris


More information about the Intel-gfx mailing list