[PATCH] drm/i915: fix missing linux/debugfs.h includes

[Danilo Krummrich]

On 4/30/24 16:53, Jani Nikula wrote:
> On Tue, 30 Apr 2024, Danilo Krummrich <dakr at redhat.com> wrote:
>> After dropping linux/debugfs.h include from drm/drm_print.h the following
>> files in i915 miss the linux/debugfs.h include: i915_debugfs.c,
>> i915_debugfs_params.c and i915_gpu_error.c.
>>
>> Add the include to fix the corresponding build errors.
>>
>> Reported-by: kernel test robot <lkp at intel.com>
>> Fixes: 33d5ae6cacf4 ("drm/print: drop include debugfs.h and include where needed")
>> Closes: https://lore.kernel.org/oe-kbuild-all/202404260726.nyGuvl59-lkp@intel.com/
>> Signed-off-by: Danilo Krummrich <dakr at redhat.com>
> 
> Thanks, but it's already fixed by commit 7fa043eafdb7 ("drm/i915: fix
> build with missing debugfs includes") in drm-next.

Even better, note that drm-misc-next is still broken though.

- Danilo

> 
> BR,
> Jani.
> 
> 
>> ---
>>   drivers/gpu/drm/i915/i915_debugfs.c        | 1 +
>>   drivers/gpu/drm/i915/i915_debugfs_params.c | 1 +
>>   drivers/gpu/drm/i915/i915_gpu_error.c      | 1 +
>>   3 files changed, 3 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
>> index 24c78873b3cf..b552e27cdcd5 100644
>> --- a/drivers/gpu/drm/i915/i915_debugfs.c
>> +++ b/drivers/gpu/drm/i915/i915_debugfs.c
>> @@ -26,6 +26,7 @@
>>    *
>>    */
>>   
>> +#include <linux/debugfs.h>
>>   #include <linux/sched/mm.h>
>>   #include <linux/sort.h>
>>   #include <linux/string_helpers.h>
>> diff --git a/drivers/gpu/drm/i915/i915_debugfs_params.c b/drivers/gpu/drm/i915/i915_debugfs_params.c
>> index 8bca02025e09..295486b8ceb1 100644
>> --- a/drivers/gpu/drm/i915/i915_debugfs_params.c
>> +++ b/drivers/gpu/drm/i915/i915_debugfs_params.c
>> @@ -3,6 +3,7 @@
>>    * Copyright © 2019 Intel Corporation
>>    */
>>   
>> +#include <linux/debugfs.h>
>>   #include <linux/kernel.h>
>>   
>>   #include "i915_debugfs_params.h"
>> diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c b/drivers/gpu/drm/i915/i915_gpu_error.c
>> index 2594eb10c559..625b3c024540 100644
>> --- a/drivers/gpu/drm/i915/i915_gpu_error.c
>> +++ b/drivers/gpu/drm/i915/i915_gpu_error.c
>> @@ -28,6 +28,7 @@
>>    */
>>   
>>   #include <linux/ascii85.h>
>> +#include <linux/debugfs.h>
>>   #include <linux/highmem.h>
>>   #include <linux/nmi.h>
>>   #include <linux/pagevec.h>
>>
>> base-commit: 4a9a567ab101e659a4fafb7a691ff6b84531a10a
>