<div class="gmail_quote">On Fri, Oct 7, 2011 at 11:08, Jesse Barnes <<a href="mailto:jbarnes@virtuousgeek.org">jbarnes@virtuousgeek.org</a>> wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;"> <div class="im">On Thu, 6 Oct 2011 20:30:35 -0300 Eugeni Dodonov <<a href="mailto:eugeni@dodonov.net">eugeni@dodonov.net</a>> wrote: > From: Eugeni Dodonov <<a href="mailto:eugeni.dodonov@intel.com">eugeni.dodonov@intel.com</a>> > > This allows to avoid talking to a non-existent bus repeatedly until we > finally timeout. The non-existent bus is signalled by -ENXIO error, > provided by i2c_algo_bit:bit_doAddress call. > > As the advantage of such change, all the other routines which use > drm_get_edid would benefit for this timeout. > > As the disadvantage comes the fact that I only tested it on Intel > cards, so I am not sure whether it would work on nouveau and radeon. > > This change should potentially fix > <a href="https://bugs.freedesktop.org/show_bug.cgi?id=41059" target="_blank">https://bugs.freedesktop.org/show_bug.cgi?id=41059</a> </div>I think I like this, assuming i2c doesn't lie to us. But won't we spam the log quite a bit? We do detection a lot because userspace often polls it and performs detection at app startup a lot. </blockquote><div> This extra logging is there just for making it easy to see when the outputs come and go. For the final version, we could use a KERN_DEBUG instead. </div></div> -- Eugeni Dodonov<a href="http://eugeni.dodonov.net/" target="_blank"> </a>