<div class="gmail_quote">On Tue, Nov 22, 2011 at 20:58, Ben Widawsky <<a href="mailto:ben@bwidawsk.net">ben@bwidawsk.net</a>> wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;"> Many of the old fields from Ironlake have gone away. Strip all those fields, and try to update to fields people care about. RC information isn't exactly ideal anymore. All we can guarantee when we read the register is that we're not using forcewake, ie. the software isn't forcing the hardware to stay awake. The downside is that in doing this we may wait a while and that causes an unnaturally idle state on the GPU. Bugzilla: <a href="https://bugs.freedesktop.org/show_bug.cgi?id=42578" target="_blank">https://bugs.freedesktop.org/show_bug.cgi?id=42578</a> Cc: Eugeni Dodonov <<a href="mailto:eugeni.dodonov@intel.com">eugeni.dodonov@intel.com</a>> Signed-off-by: Ben Widawsky <<a href="mailto:ben@bwidawsk.net">ben@bwidawsk.net</a>> </blockquote><div> For both patches: Reviewed-by: Eugeni Dodonov <<a href="mailto:eugeni.dodonov@intel.com">eugeni.dodonov@intel.com</a>> Just one comment below. </div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">+ if (count == 50) + DRM_INFO("Couldn't get accurate RC information\n"); </blockquote><div> Maybe we should seq_printf() this as well? Like, for example: seq_printf(m, "RC information accurate: %s\n", yesno(count != 50)); So the userspace consulting this file would know if it should rely on the values or retry the read.. Just an idea. </div></div> -- Eugeni Dodonov<a href="http://eugeni.dodonov.net/" target="_blank"> </a>