<div class="gmail_quote">On Sat, Nov 19, 2011 at 00:24, Ben Widawsky <<a href="mailto:ben@bwidawsk.net" target="_blank">ben@bwidawsk.net</a>> wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> This code is currently living on my personal git repo: git://<a href="http://people.freedesktop.org/%7Ebwidawsk/drm-intel" target="_blank">people.freedesktop.org/~bwidawsk/drm-intel</a> forced_throttling Since these are RFC, I haven't spent too much time cleaning things up. Feel free to comment on typos, comments you feel are missing, etc. I also haven't spent any time running the standard kernel tests, kmemleak and such - I intend to do so while these are reviewed here. There are two main "scheduler" types implemented in this patch. What I refer to as a fairness scheduler, and a batch scheduler. The fairness scheduler is currently implemented on batch granularity but that is not guaranteed going forward. The batch scheduler is a way to set batch limits per pid. Refer to the relevant patch for more details. It is my opinion that the fairness scheduler isn't terribly interesting except to prevent badly written, or malicious apps. For example, a 3d app which queues up a ton of work but never calls glxSwapBuffer. The batch scheduler is also somewhat uninteresting as the values it uses require proper tuning and will vary from system to system, and even then depending on what's currently running. But like the fairness one, this too has its applications. Most comments and feedback are welcome. </blockquote><div> I am not that expert about how GPU scheduling works, but all the patches make sense to me and I haven't found anything apparently wrong. I have one feature request for patch 11, which is to list available schedulers via a debugfs entry. For example: # cat /sys/kernel/debug/dri/0/i915_available_schedulers none *fair batch or list them in the output of i915_scheduler, like: # cat /sys/kernel/debug/dri/0/i915_scheduler ... Scheduler: batch Available schedulers: none fair batch To see what schedulers are available for usage. But besides this, for the series: Tested-by: Eugeni Dodonov <<a href="mailto:eugeni.dodonov@intel.com" target="_blank">eugeni.dodonov@intel.com</a>> Reviewed-by: Eugeni Dodonov <<a href="mailto:eugeni.dodonov@intel.com" target="_blank">eugeni.dodonov@intel.com</a>> </div></div>-- Eugeni Dodonov<a href="http://eugeni.dodonov.net/" target="_blank"> </a>