<div class="gmail_quote">On Mon, Jan 9, 2012 at 12:03, <<a href="mailto:przanoni@gmail.com">przanoni@gmail.com</a>> wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> From: Paulo Zanoni <<a href="mailto:paulo.r.zanoni@intel.com">paulo.r.zanoni@intel.com</a>> This is a command-line tool that allows us to display and modify the InfoFrames we send. Signed-off-by: Paulo Zanoni <<a href="mailto:paulo.r.zanoni@intel.com">paulo.r.zanoni@intel.com</a>> </blockquote><div> Very interesting! I think that it would be more interesting to use command line options instead of interactive input - something like: -d, --dump -c, --change [parameters] -dd, --dip-disable -de, --dip-enable [parameters] -hd, --hdmi-disable -he, --hdmi-enable [parameters] So this could be scripted and used non-interactively. This would also simplify your change_avi_infoframe and parse_infoframe_option_s - you could just pass all the values as parameters instead. </div></div>Other than that, Reviewed-by: Eugeni Dodonov <<a href="mailto:eugeni.dodonov@intel.com">eugeni.dodonov@intel.com</a>> -- Eugeni Dodonov<a href="http://eugeni.dodonov.net/" target="_blank"> </a>