<div class="gmail_quote">On Thu, Jan 12, 2012 at 21:13, Vincent Vanackere <<a href="mailto:vincent.vanackere@gmail.com">vincent.vanackere@gmail.com</a>> wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> <div class="HOEnZb"><div class="h5"> <div class="gmail_quote">On Thu, Jan 12, 2012 at 20:57, Jesse Barnes <<a href="mailto:jbarnes@virtuousgeek.org" target="_blank">jbarnes@virtuousgeek.org</a>> wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> <div><div>On Thu, 12 Jan 2012 17:29:38 -0200 Eugeni Dodonov <<a href="mailto:eugeni@dodonov.net" target="_blank">eugeni@dodonov.net</a>> wrote: > On Thu, Jan 12, 2012 at 17:25, Jesse Barnes <<a href="mailto:jbarnes@virtuousgeek.org" target="_blank">jbarnes@virtuousgeek.org</a>>wrote: > > > On Thu, 12 Jan 2012 20:08:59 +0100 > > Vincent Vanackere <<a href="mailto:vincent.vanackere@gmail.com" target="_blank">vincent.vanackere@gmail.com</a>> wrote: > > > > Thanks for the report... do you also have: > > > > > > > > commit 7a4198664d46b87025a64530f1530ab2bea54c19 > > > > Author: Jesse Barnes <<a href="mailto:jbarnes@virtuousgeek.org" target="_blank">jbarnes@virtuousgeek.org</a>> > > > > Date: Tue Nov 15 10:28:53 2011 -0800 > > > > > > > > drm/i915: don't disable a PCH DPLL that's in use > > > > > > > > > > > > commit d8e70a254d8f2da141006e496a51502b79115e80 > > > > Author: Jesse Barnes <<a href="mailto:jbarnes@virtuousgeek.org" target="_blank">jbarnes@virtuousgeek.org</a>> > > > > Date: Tue Nov 15 10:28:54 2011 -0800 > > > > > > > > drm/i915: only set the intel_crtc DPMS mode to on if the mode set > > > > succeeded > > > > > > > > in your tree? Those are needed to fix some 3 pipe related bugs. > > > > > > > > -- > > > > Jesse Barnes, Intel Open Source Technology Center > > > > > > > > > > Yes, these commits were present. To double-check I just tested the latest > > > tip at a429638cac1e5c656818a45aaff78df7b743004e and the problem is still > > > there. > > > > Stefan, you have the same machine? I wonder if it's an eDP config; my > > t420 here works ok with current bits, but it uses LVDS. > > > > If you are using eDP, you might be facing > <a href="https://bugs.freedesktop.org/show_bug.cgi?id=42263" target="_blank">https://bugs.freedesktop.org/show_bug.cgi?id=42263</a> or > <a href="https://bugs.freedesktop.org/show_bug.cgi?id=42278" target="_blank">https://bugs.freedesktop.org/show_bug.cgi?id=42278</a>. > > Could you try with patch mentioned at > <a href="https://bugs.freedesktop.org/show_bug.cgi?id=42263" target="_blank">https://bugs.freedesktop.org/show_bug.cgi?id=42263</a> reverted? </div></div>Also can you try this patch as a sanity check? You may need to set up netconsole to capture the BUG_ON if you hit it. <div> -- Jesse Barnes, Intel Open Source Technology Center </div>diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index 29743de..d01f403 100644 --- a/drivers/gpu/drm/i915/intel_display.c +++ b/drivers/gpu/drm/i915/intel_display.c @@ -2921,6 +2921,7 @@ static void ironlake_pch_enable(struct drm_crtc *crtc) temp &= ~(TRANSB_DPLLB_SEL); temp |= (TRANSB_DPLL_ENABLE | TRANSB_DPLLB_SEL); } else if (pipe == 2) { + BUG_ON(!IS_IVYBRIDGE(dev)); temp &= ~(TRANSC_DPLLB_SEL); temp |= (TRANSC_DPLL_ENABLE | transc_sel); } @@ -3114,6 +3115,7 @@ static void ironlake_crtc_disable(struct drm_crtc *crtc) temp &= ~(TRANSB_DPLL_ENABLE | TRANSB_DPLLB_SEL); break; case 2: + BUG_ON(!IS_IVYBRIDGE(dev)); /* C shares PLL A or B */ temp &= ~(TRANSC_DPLL_ENABLE | TRANSC_DPLLB_SEL); break; @@ -3126,6 +3128,8 @@ static void ironlake_crtc_disable(struct drm_crtc *crtc) /* disable PCH DPLL */ if (!intel_crtc->no_pll) intel_disable_pch_pll(dev_priv, pipe); + else + BUG_ON(!IS_IVYBRIDGE(dev)); /* Switch from PCDclk to Rawclk */ reg = FDI_RX_CTL(pipe); @@ -5787,6 +5791,8 @@ static int ironlake_crtc_mode_set(struct drm_crtc *crtc, udelay(150); } } else { + BUG_ON(!IS_IVYBRIDGE(dev)); + if (dpll == (I915_READ(PCH_DPLL(0)) & 0x7fffffff) && fp == I915_READ(PCH_FP0(0))) { intel_crtc->use_pll_a = true; </blockquote></div> </div></div>Will try. In the meantime I'm attaching the dmesg of a faulty kernel using drm.debug=4 in case it helps. </blockquote></div> ... and I just noticed this part of the log that may be of interest : <pre>[ 5.191208] WARNING: at drivers/gpu/drm/i915/intel_display.c:813 ironlake_crtc_enable+0x989/0x9b0 [i915]() [ 5.191211] Hardware name: 78595AG [ 5.191212] transcoder 0 PLL not enabled [ 5.191213] Modules linked in: joydev arc4 snd_hda_intel(+) snd_hda_codec snd_hwdep snd_pcm thinkpad_acpi snd_seq_midi snd_rawmidi snd_seq_midi_event i915(+) snd_seq iwlwifi snd_timer snd_seq_device drm_kms_helper mac80211 drm snd cfg80211 psmouse serio_raw snd_page_alloc mei(C) soundcore nvram video wmi tpm_tis binfmt_misc ahci libahci r8169 btrfs zlib_deflate libcrc32c [ 5.191235] Pid: 608, comm: modprobe Tainted: G C 3.2.0-custom+ #11 [ 5.191237] Call Trace: [ 5.191244] [<ffffffff8104e30f>] warn_slowpath_common+0x7f/0xc0 [ 5.191247] [<ffffffff8104e406>] warn_slowpath_fmt+0x46/0x50 [ 5.191260] [<ffffffffa02a35c9>] ironlake_crtc_enable+0x989/0x9b0 [i915] [ 5.191270] [<ffffffffa02a35fe>] ironlake_crtc_commit+0xe/0x10 [i915] [ 5.191276] [<ffffffffa0165fb5>] drm_crtc_helper_set_mode+0x3e5/0x520 [drm_kms_helper] [ 5.191282] [<ffffffffa0166fbf>] drm_crtc_helper_set_config+0x83f/0xaf0 [drm_kms_helper] [ 5.191287] [<ffffffffa0164bcc>] drm_fb_helper_set_par+0x7c/0xf0 [drm_kms_helper] [ 5.191290] [<ffffffff8133790c>] fbcon_init+0x52c/0x5b0 [ 5.191294] [<ffffffff81390f03>] visual_init+0xd3/0x190 [ 5.191297] [<ffffffff813926c9>] bind_con_driver+0x249/0x490 [ 5.191300] [<ffffffff81392971>] take_over_console+0x61/0x70 [ 5.191303] [<ffffffff81332cbb>] fbcon_takeover+0x5b/0xb0 [ 5.191306] [<ffffffff813385ba>] fbcon_event_notify+0x76a/0x870 [ 5.191310] [<ffffffff815a082d>] notifier_call_chain+0x4d/0x70 [ 5.191313] [<ffffffff81076868>] __blocking_notifier_call_chain+0x58/0x80 [ 5.191316] [<ffffffff810768a6>] blocking_notifier_call_chain+0x16/0x20 [ 5.191319] [<ffffffff8132836b>] fb_notifier_call_chain+0x1b/0x20 [ 5.191322] [<ffffffff813295da>] register_framebuffer+0x1ba/0x2f0 [ 5.191326] [<ffffffffa0164e23>] drm_fb_helper_single_fb_probe+0x1e3/0x300 [drm_kms_helper] [ 5.191330] [<ffffffffa016511b>] drm_fb_helper_initial_config+0x1db/0x250 [drm_kms_helper] [ 5.191334] [<ffffffffa01652a8>] ? drm_fb_helper_init+0x118/0x200 [drm_kms_helper] [ 5.191338] [<ffffffff81140a1c>] ? kmem_cache_alloc_trace+0x10c/0x140 [ 5.191342] [<ffffffffa01653df>] ? drm_fb_helper_single_add_all_connectors+0x4f/0x100 [drm_kms_helper] [ 5.191357] [<ffffffffa02b5176>] intel_fbdev_init+0x96/0xd0 [i915] [ 5.191368] [<ffffffffa027e778>] i915_driver_load+0xea8/0x10c0 [i915] [ 5.191373] [<ffffffff813b7e2e>] ? device_register+0x1e/0x30 [ 5.191384] [<ffffffffa01fe506>] ? drm_sysfs_device_add+0x86/0xb0 [drm] [ 5.191388] [<ffffffff812edab5>] ? kobject_uevent_env+0x115/0x480 [ 5.191397] [<ffffffffa01fcc69>] drm_get_pci_dev+0x199/0x2c0 [drm] [ 5.191412] [<ffffffffa02bf517>] i915_pci_probe+0x1b/0x1d [i915] [ 5.191415] [<ffffffff81310eac>] local_pci_probe+0x5c/0xd0 [ 5.191419] [<ffffffff81312749>] pci_device_probe+0x109/0x130 [ 5.191422] [<ffffffff813ba5be>] driver_probe_device+0x7e/0x1b0 [ 5.191424] [<ffffffff813ba79b>] __driver_attach+0xab/0xb0 [ 5.191427] [<ffffffff813ba6f0>] ? driver_probe_device+0x1b0/0x1b0 [ 5.191429] [<ffffffff813ba6f0>] ? driver_probe_device+0x1b0/0x1b0 [ 5.191433] [<ffffffff813b957c>] bus_for_each_dev+0x5c/0x90 [ 5.191436] [<ffffffff813ba24e>] driver_attach+0x1e/0x20 [ 5.191439] [<ffffffff813b9ea0>] bus_add_driver+0x1a0/0x270 [ 5.191442] [<ffffffff813bace6>] driver_register+0x76/0x140 [ 5.191445] [<ffffffff81312426>] __pci_register_driver+0x56/0xd0 [ 5.191448] [<ffffffff815a082d>] ? notifier_call_chain+0x4d/0x70 [ 5.191457] [<ffffffffa01fceaa>] drm_pci_init+0x11a/0x130 [drm] [ 5.191460] [<ffffffffa02ea000>] ? 0xffffffffa02e9fff [ 5.191470] [<ffffffffa02ea08b>] i915_init+0x8b/0x8d [i915] [ 5.191473] [<ffffffff810001d2>] do_one_initcall+0x42/0x170 [ 5.191477] [<ffffffff8108dfa0>] sys_init_module+0xc0/0x230 [ 5.191481] [<ffffffff815a4a6b>] system_call_fastpath+0x16/0x1b [ 5.191483] ---[ end trace 4e5a5bf7b208c0b2 ]---</pre>