<br><br><div class="gmail_quote">On Thu, Jan 12, 2012 at 21:49, Jesse Barnes <span dir="ltr"><<a href="mailto:jbarnes@virtuousgeek.org" target="_blank">jbarnes@virtuousgeek.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
On Thu, 12 Jan 2012 21:37:11 +0100<br>
<div><div>Vincent Vanackere <<a href="mailto:vincent.vanackere@gmail.com" target="_blank">vincent.vanackere@gmail.com</a>> wrote:<br>
<br>
> On Thu, Jan 12, 2012 at 21:17, Jesse Barnes <<a href="mailto:jbarnes@virtuousgeek.org" target="_blank">jbarnes@virtuousgeek.org</a>>wrote:<br>
><br>
> > On Thu, 12 Jan 2012 21:13:40 +0100<br>
> > Vincent Vanackere <<a href="mailto:vincent.vanackere@gmail.com" target="_blank">vincent.vanackere@gmail.com</a>> wrote:<br>
[...]<br>
> > Another one to try... need to check if we're masking out the port<br>
> > selection bits correctly...<br>
> ><br>
> > --<br>
> > Jesse Barnes, Intel Open Source Technology Center<br>
> ><br>
> > @@ -5808,12 +5814,15 @@ static int ironlake_crtc_mode_set(struct drm_crtc<br>
> > *crtc,<br>
> > if (is_lvds) {<br>
> > temp = I915_READ(PCH_LVDS);<br>
> > temp |= LVDS_PORT_EN | LVDS_A0A2_CLKA_POWER_UP;<br>
> > - if (HAS_PCH_CPT(dev))<br>
> > + if (HAS_PCH_CPT(dev)) {<br>
> > + temp &= ~PORT_TRANS_SEL_MASK;<br>
> > temp |= PORT_TRANS_SEL_CPT(pipe);<br>
> > - else if (pipe == 1)<br>
> > - temp |= LVDS_PIPEB_SELECT;<br>
> > - else<br>
> > - temp &= ~LVDS_PIPEB_SELECT;<br>
> > + } else {<br>
> > + if (pipe == 1)<br>
> > + temp |= LVDS_PIPEB_SELECT;<br>
> > + else<br>
> > + temp &= ~LVDS_PIPEB_SELECT;<br>
> > + }<br>
> ><br>
> > /* set the corresponsding LVDS_BORDER bit */<br>
> > temp |= dev_priv->lvds_border_bits;<br>
> ><br>
> ><br>
> Against which tree do these patches apply ?<br>
<br>
</div></div>I was using the drm-intel-next branch of keithp's tree on<br>
<a href="http://freedesktop.org" target="_blank">freedesktop.org</a>, but they should also apply with some fuzz against<br>
Linus's current master tree.<br></blockquote></div><br>I'm happy to report that this patch indeed fixes the issue for me (tested both on linus' master and drm-intel-next). <br>Note that I had to apply it by hand (the patch was mangled by your mailer ?), therefore I'm resending your fix as an attachment in case other people are interested.<br>
<br>Many thanks for the quick fix !<br><br>Vincent<br><br>