<div class="gmail_quote">On Tue, Apr 17, 2012 at 05:57, Daniel Vetter <span dir="ltr"><<a href="mailto:daniel@ffwll.ch">daniel@ffwll.ch</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="im">On Mon, Apr 16, 2012 at 10:20:33PM -0300, Eugeni Dodonov wrote:<br>
> As Chris Wilson noticed, my previous patch that did the refactoring as one big<br>
> patch which moved everything at once was extremely difficult to review and<br>
> maintain. So I split the same refactoring into a series of smaller patches,<br>
> which move one subsystem at a time.<br>
<br>
</div>Yeah, diffs are not actually readable, so looks like we have to do this<br>
piece-wise.</blockquote><div><br></div><div>Please, tell me that you meant 'diffs are *now* actually readable' with a 'not' being a typo instead of 'now' there by a chance...</div><div><br></div><div>
Because otherwise I couldn't understand what you meant with piece-wise. Should I move each function at a time? :)</div><div><br></div><div>I'll do the intel_pm_init (or intel_init_pm) and send it on top of this series. It makes lots of sense and will avoid exposing all those platform-specific stuff where we won't need it except for initialization.</div>
<div><br></div></div>-- <br>Eugeni Dodonov<a href="http://eugeni.dodonov.net/" target="_blank"><br></a><br>