<div class="gmail_quote">On Wed, May 2, 2012 at 10:55 PM, Paulo Zanoni <span dir="ltr"><<a href="mailto:przanoni@gmail.com" target="_blank">przanoni@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
From: Paulo Zanoni <<a href="mailto:paulo.r.zanoni@intel.com" target="_blank">paulo.r.zanoni@intel.com</a>><br>
<br>
That's what the VIDEO_DIP_CTL documentation says we need to do. Except<br>
when it's the AVI InfoFrame and we're ironlake_write_infoframe.<br>
<br>
Signed-off-by: Paulo Zanoni <<a href="mailto:paulo.r.zanoni@intel.com" target="_blank">paulo.r.zanoni@intel.com</a>><br></blockquote><div><br></div><div><div>Reviewed-by: Eugeni Dodonov <<a href="mailto:eugeni.dodonov@intel.com" target="_blank">eugeni.dodonov@intel.com</a>></div>
</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> val &= ~(VIDEO_DIP_SELECT_MASK | 0xf); /* clear DIP data offset */<br>
val |= intel_infoframe_index(frame);<br>
<br>
+ if (frame->type == DIP_TYPE_AVI)<br>
+ val |= VIDEO_DIP_ENABLE_AVI;<br>
+ else<br>
+ val &= ~intel_infoframe_enable(frame);<br>
+<br></blockquote><div><br></div><div>Maybe adding a comment here saying why we have this on Ironlake as well?</div><div> </div></div>-- <br>Eugeni Dodonov<a href="http://eugeni.dodonov.net/" target="_blank"><br></a><br>