<div class="gmail_quote">On Sun, May 13, 2012 at 8:35 PM, Eugeni Dodonov <span dir="ltr"><<a href="mailto:eugeni@dodonov.net" target="_blank">eugeni@dodonov.net</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">


<div class="gmail_quote"><div>On Sun, May 13, 2012 at 5:54 AM, Chris Wilson <span dir="ltr"><<a href="mailto:chris@chris-wilson.co.uk" target="_blank">chris@chris-wilson.co.uk</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">



+       intel_enable_pch_pll(intel_crtc);<br>
+<br>
        if (HAS_PCH_LPT(dev)) {<br>
                DRM_DEBUG_KMS("LPT detected: programming iCLKIP\n");<br>
                lpt_program_iclkip(crtc);<br>
        } else if (HAS_PCH_CPT(dev)) {<br></blockquote><div><br></div></div><div>Could we just replace this 'else if()' with 'else' to achieve the same functionality? This way, everything will work and we won't touch wrong registers on LPT.</div>


</div></blockquote><div><br></div><div>Err, English fail here from my side. What I thought was:</div><div><br></div><div><span>       if (HAS_PCH_LPT(dev)) {</span><br><span>               DRM_DEBUG_KMS("LPT detected: programming iCLKIP\n");</span><br>


<span>               lpt_program_iclkip(crtc);</span><br><span>       } else</span></div><span>               intel_enable_pch_pll(intel_</span><span>crtc);</span><br><div><span>              </span></div>
<div><span>if (HAS_PCH_CPT(dev)) {</span><br><span>       u32 sel;</span><br><span>       temp = I915_READ(PCH_DPLL_SEL);</span></div><div><span>       switch (pipe) {</span><br><span>       default:</span></div>
<div>...</div><div><br></div></div>-- <br>Eugeni Dodonov<a href="http://eugeni.dodonov.net/" target="_blank"><br></a><br>