<div class="gmail_quote">On Thu, May 24, 2012 at 1:22 PM, Jesse Barnes <span dir="ltr"><<a href="mailto:jbarnes@virtuousgeek.org" target="_blank">jbarnes@virtuousgeek.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">

 static ssize_t<br>
+i915_min_freq_read(struct file *filp,<br>
+                  char __user *ubuf,<br>
+                  size_t max,<br>
+                  loff_t *ppos)<br>
+{<br>
+       struct drm_device *dev = filp->private_data;<br>
+       drm_i915_private_t *dev_priv = dev->dev_private;<br>
+       char buf[80];<br></blockquote><div><br></div><div><bikeshed></div><div>I think 20 characters, as in min_freq_write, would be enough here.</div><div></bikeshed> </div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">

+       /*<br>
+        * Turbo will still be enabled, but won't go above the set value.<br>
+        */<br>
+       dev_priv->min_delay = val / 50;<br></blockquote><div><br></div><div>I guess the comment here is meant to say that turbo won't go below the set value.</div><div><br></div><div>But other than that,</div><div>

Reviewed-by: Eugeni Dodonov <<a href="mailto:eugeni.dodonov@intel.com">eugeni.dodonov@intel.com</a>></div></div><div><br></div>-- <br>Eugeni Dodonov<a href="http://eugeni.dodonov.net/" target="_blank"><br></a><br>