<br><br><div class="gmail_quote">2013/8/7 Daniel Vetter <span dir="ltr"><<a href="mailto:daniel@ffwll.ch" target="_blank">daniel@ffwll.ch</a>></span><br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;padding-left:1ex;border-left-color:rgb(204,204,204);border-left-width:1px;border-left-style:solid">
<div class="HOEnZb"><div class="h5">On Wed, Aug 7, 2013 at 2:01 PM, Inki Dae <<a href="mailto:inki.dae@samsung.com">inki.dae@samsung.com</a>> wrote:<br>
><br>
><br>
> 2013/8/7 Daniel Vetter <<a href="mailto:daniel@ffwll.ch">daniel@ffwll.ch</a>><br>
>><br>
>> On Wed, Aug 07, 2013 at 07:18:45PM +0900, Joonyoung Shim wrote:<br>
>> > On 08/07/2013 06:55 PM, Daniel Vetter wrote:<br>
>> > >On Wed, Aug 7, 2013 at 11:40 AM, Inki Dae <<a href="mailto:inki.dae@samsung.com">inki.dae@samsung.com</a>> wrote:<br>
>> > >>>-----Original Message-----<br>
>> > >>>From: Daniel Vetter [mailto:<a href="mailto:daniel.vetter@ffwll.ch">daniel.vetter@ffwll.ch</a>]<br>
>> > >>>Sent: Wednesday, August 07, 2013 6:15 PM<br>
>> > >>>To: DRI Development<br>
>> > >>>Cc: Intel Graphics Development; Daniel Vetter; Inki Dae<br>
>> > >>>Subject: [PATCH 1/3] drm: use common drm_gem_dmabuf_release in<br>
>> > >>> i915/exynos<br>
>> > >>>drivers<br>
>> > >>><br>
>> > >>>Note that this is slightly tricky since both drivers store their<br>
>> > >>>native objects in dma_buf->priv. But both also embed the base<br>
>> > >>>drm_gem_object at the first position, so the implicit cast is ok.<br>
>> > >>><br>
>> > >>>To use the release helper we need to export it, too.<br>
>> > >>Yeah, may I repost this patch with additional work? We also need to<br>
>> > >> export<br>
>> > >>with a gem object instead of specific one like you did.<br>
>> ><br>
>> > I think dmabuf stuff of exynos can be replaced to common drm_gem_dmabuf.<br>
>> > Already dmabuf stuff of drm_gem_cma_helper.c was substituted to common<br>
>> > drm_gem_dmabuf with low-level hook functions to use prime helpers.<br>
>><br>
>> Ah, but that can easily be done on top of this, right?<br>
><br>
><br>
> Daniel, could you remove exynos related codes from your patch set? Your<br>
> patch set would make exynos broken because you didn't consider exporting<br>
> with a gem object for exynos like [PATCH 3/3] drm/i915: explicit store base<br>
> gem object in dma_buf->priv. So I think your patch set is not complete set,<br>
> and That is why exynos needs the additional work I mentioned above. So I<br>
> just wanted to repost your patch set + new one.<br>
<br>
</div></div>Nope, my patch should not break exynos since the base gem_object is<br>
the first member of the exynos object, so we don't have any issues<br></blockquote><div><div> </div><div>Ah, right. However, it does not seem like good way.</div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;padding-left:1ex;border-left-color:rgb(204,204,204);border-left-width:1px;border-left-style:solid">
with upcasting in exynos dma-buf code. The same applies to i915<br>
dma-buf code, my follow-up patch just makes the code a bit safer.<br>
<div class="im"><br> </div></blockquote><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;padding-left:1ex;border-left-color:rgb(204,204,204);border-left-width:1px;border-left-style:solid"><div class="im"> </div>
</blockquote><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;padding-left:1ex;border-left-color:rgb(204,204,204);border-left-width:1px;border-left-style:solid"><div class="im"> </div></blockquote><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;padding-left:1ex;border-left-color:rgb(204,204,204);border-left-width:1px;border-left-style:solid">
<div class="im">
> However, I think not only exynos could go to common drm_gem_dmabuf directly<br>
> but also it would make your patch set to be complete set if you remove<br>
> exynos related codes from your patch set. Otherwise, we have to work twice.<br>
> one is the additional work for resolving exynos broken issue by your patch<br>
> set, and other is to replace existing dmabuf stuff of exynos to common<br>
> drm_gem_dmabuf.<br>
<br>
</div>Yeah np, I'll drop exynos then.<br></blockquote><div> </div><div>Thanks a lot. :)</div><div> </div><div>Thanks,</div><div>Inki Dae</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;padding-left:1ex;border-left-color:rgb(204,204,204);border-left-width:1px;border-left-style:solid">
<div class="HOEnZb"><div class="h5">-Daniel<br>
--<br>
Daniel Vetter<br>
Software Engineer, Intel Corporation<br>
+41 (0) 79 365 57 48 - <a href="http://blog.ffwll.ch" target="_blank">http://blog.ffwll.ch</a><br>
_______________________________________________<br>
dri-devel mailing list<br>
<a href="mailto:dri-devel@lists.freedesktop.org">dri-devel@lists.freedesktop.org</a><br>
<a href="http://lists.freedesktop.org/mailman/listinfo/dri-devel" target="_blank">http://lists.freedesktop.org/mailman/listinfo/dri-devel</a><br>
</div></div></blockquote></div><br>