<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On Thu, Sep 4, 2014 at 2:22 AM, Daniel Vetter <span dir="ltr"><<a href="mailto:daniel@ffwll.ch" target="_blank">daniel@ffwll.ch</a>></span> wrote:<br> <blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div class="">On Wed, Sep 03, 2014 at 10:49:56PM -0400, Rodrigo Vivi wrote:<br> </div><div class="">> With Software tracking we are going to PSR sooner than we should and staying<br> > with blank screens in many cases.<br> ><br> > Using 2 identical frames to detect idleness is safier.<br> ><br> > Discovered and validated with refactored igt/kms_sink_psr_crc.<br> ><br> > Signed-off-by: Rodrigo Vivi <<a href="mailto:rodrigo.vivi@intel.com">rodrigo.vivi@intel.com</a>><br> > ---<br> > drivers/gpu/drm/i915/intel_dp.c | 2 +-<br> > 1 file changed, 1 insertion(+), 1 deletion(-)<br> ><br> > diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c<br> > index f79473b..a796831 100644<br> > --- a/drivers/gpu/drm/i915/intel_dp.c<br> > +++ b/drivers/gpu/drm/i915/intel_dp.c<br> > @@ -1813,7 +1813,7 @@ static void intel_edp_psr_enable_source(struct intel_dp *intel_dp)<br> > struct drm_device *dev = dig_port->base.base.dev;<br> > struct drm_i915_private *dev_priv = dev->dev_private;<br> > uint32_t max_sleep_time = 0x1f;<br> > - uint32_t idle_frames = 1;<br> > + uint32_t idle_frames = 2;<br> <br> </div>Hm, that sounds like we allow psr before it is really possible. And we<br> still delay the actual re-enable work by 100ms, so it very much looks like<br> something is broken here.<br></blockquote><div><br></div><div><br>Agree. leaving idle_frame = 1 and increasing time to 600ms also works.</div><div>500ms fails.<br>So I thought we had an issue with frontbuffer tracking but couldn find any.</div> <div>So this idle_frame = 2 was the most clear way I could find for now.</div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"> <br> Which exact subcases do fail?<br></blockquote><div><br></div><div>Here are the results with idle_frame=1<br></div><div><div>IGT-Version: 1.7-gdee8754 (x86_64) (Linux: 3.17.0-rc2+ x86_64)</div><div>Test assertion failure function get_sink_crc, file kms_psr_sink_crc.c:271:</div> <div>Failed assertion: strcmp(crc, CRC_BLACK) != 0</div><div>Subtest primary_page_flip: FAIL</div><div>Test assertion failure function get_sink_crc, file kms_psr_sink_crc.c:271:</div><div>Failed assertion: strcmp(crc, CRC_BLACK) != 0</div> <div>Subtest primary_mmap_gtt: FAIL</div><div>Test assertion failure function get_sink_crc, file kms_psr_sink_crc.c:271:</div><div>Failed assertion: strcmp(crc, CRC_BLACK) != 0</div><div>Subtest primary_mmap_gtt_waiting: FAIL</div> <div>Test assertion failure function get_sink_crc, file kms_psr_sink_crc.c:271:</div><div>Failed assertion: strcmp(crc, CRC_BLACK) != 0</div><div>Subtest primary_mmap_cpu: FAIL</div><div>Test assertion failure function get_sink_crc, file kms_psr_sink_crc.c:271:</div> <div>Failed assertion: strcmp(crc, CRC_BLACK) != 0</div><div>Subtest primary_blt: FAIL</div><div>Subtest primary_render: SUCCESS</div><div>Subtest sprite_mmap_gtt: SUCCESS</div><div>Waiting 10s...</div><div>Subtest sprite_mmap_gtt_waiting: SUCCESS</div> <div>Subtest sprite_mmap_cpu: SUCCESS</div><div>Subtest sprite_blt: SUCCESS</div><div>Subtest sprite_render: SUCCESS</div><div>Subtest sprite_plane_move: SUCCESS</div><div>Test assertion failure function get_sink_crc, file kms_psr_sink_crc.c:271:</div> <div>Failed assertion: strcmp(crc, CRC_BLACK) != 0</div><div>Subtest sprite_plane_onoff: FAIL</div><div>Test assertion failure function get_sink_crc, file kms_psr_sink_crc.c:271:</div><div>Failed assertion: strcmp(crc, CRC_BLACK) != 0</div> <div>Subtest cursor_mmap_gtt: FAIL</div><div>Test assertion failure function get_sink_crc, file kms_psr_sink_crc.c:271:</div><div>Failed assertion: strcmp(crc, CRC_BLACK) != 0</div><div>Subtest cursor_mmap_gtt_waiting: FAIL</div> <div>Test assertion failure function get_sink_crc, file kms_psr_sink_crc.c:271:</div><div>Failed assertion: strcmp(crc, CRC_BLACK) != 0</div><div>Subtest cursor_mmap_cpu: FAIL</div><div>Test assertion failure function get_sink_crc, file kms_psr_sink_crc.c:271:</div> <div>Failed assertion: strcmp(crc, CRC_BLACK) != 0</div><div>Subtest cursor_blt: FAIL</div><div>Test assertion failure function get_sink_crc, file kms_psr_sink_crc.c:271:</div><div>Failed assertion: strcmp(crc, CRC_BLACK) != 0</div> <div>Subtest cursor_render: FAIL</div><div>Test assertion failure function get_sink_crc, file kms_psr_sink_crc.c:271:</div><div>Failed assertion: strcmp(crc, CRC_BLACK) != 0</div><div>Subtest cursor_plane_move: FAIL</div> <div>Test assertion failure function get_sink_crc, file kms_psr_sink_crc.c:271:</div><div>Failed assertion: strcmp(crc, CRC_BLACK) != 0</div></div><div>Subtest cursor_plane_onoff: FAIL </div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"> -Daniel<br> <div class="im"><br> > uint32_t val = 0x0;<br> > const uint32_t link_entry_time = EDP_PSR_MIN_LINK_ENTRY_TIME_8_LINES;<br> > bool only_standby = false;<br> > --<br> > 1.9.3<br> ><br> > _______________________________________________<br> > Intel-gfx mailing list<br> > <a href="mailto:Intel-gfx@lists.freedesktop.org">Intel-gfx@lists.freedesktop.org</a><br> > <a href="http://lists.freedesktop.org/mailman/listinfo/intel-gfx" target="_blank">http://lists.freedesktop.org/mailman/listinfo/intel-gfx</a><br> <br> </div><span class=""><font color="#888888">--<br> Daniel Vetter<br> Software Engineer, Intel Corporation<br> <a href="tel:%2B41%20%280%29%2079%20365%2057%2048" value="+41793655748">+41 (0) 79 365 57 48</a> - <a href="http://blog.ffwll.ch" target="_blank">http://blog.ffwll.ch</a><br> </font></span><div class=""><div class="h5">_______________________________________________<br> Intel-gfx mailing list<br> <a href="mailto:Intel-gfx@lists.freedesktop.org">Intel-gfx@lists.freedesktop.org</a><br> <a href="http://lists.freedesktop.org/mailman/listinfo/intel-gfx" target="_blank">http://lists.freedesktop.org/mailman/listinfo/intel-gfx</a><br> </div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div>Rodrigo Vivi</div><div>Blog: <a href="http://blog.vivi.eng.br" target="_blank">http://blog.vivi.eng.br</a></div><div> </div> </div></div>