<div dir="ltr">I really didn't like this implementation because I'm using the global variable in the test case.<div><br></div><div>So I think also providing a define igt_skip_function_on_dryrun() if (igt_dry_run) return 0 is more igt like.</div><div><br></div><div>For psr I need a way to run the testcases even when PSR is disabled to know what to expect. So dryrun on psr test case means runs even with psr disabled.</div><div>For any other feature could be something similar, run with feature disabled. Or also it can be used for any other big testcase using a local assert that do this plus igt_assert next so it can avoid fails and execute the test to the end just to check all interactions.</div><div><br></div><div>So, what do you think? I could live with my old define on code though...</div><div><br></div><div><br></div><div><br></div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Fri, Sep 5, 2014 at 1:23 AM, Daniel Vetter <span dir="ltr"><<a href="mailto:daniel@ffwll.ch" target="_blank">daniel@ffwll.ch</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On Thu, Sep 04, 2014 at 06:22:51PM -0400, Rodrigo Vivi wrote:<br>
> This allows to run tests with psr disabled and know what to expect when<br>
> PSR is actually enabled.<br>
><br>
> Signed-off-by: Rodrigo Vivi <<a href="mailto:rodrigo.vivi@intel.com">rodrigo.vivi@intel.com</a>><br>
<br>
</span>I don't really follow what this is useful for ... Can you please elaborate<br>
how this is used and how it helps debugging?<br>
-Daniel<br>
<div class="HOEnZb"><div class="h5"><br>
> ---<br>
> tests/kms_psr_sink_crc.c | 8 ++++++++<br>
> 1 file changed, 8 insertions(+)<br>
><br>
> diff --git a/tests/kms_psr_sink_crc.c b/tests/kms_psr_sink_crc.c<br>
> index 51e54a7..1380ca4 100644<br>
> --- a/tests/kms_psr_sink_crc.c<br>
> +++ b/tests/kms_psr_sink_crc.c<br>
> @@ -72,6 +72,7 @@ typedef struct {<br>
> igt_display_t display;<br>
> struct igt_fb fb[2];<br>
> igt_plane_t *plane[2];<br>
> + bool running_with_psr_disabled;<br>
> } data_t;<br>
><br>
> static const char *tests_str(enum tests test)<br>
> @@ -264,6 +265,9 @@ static bool psr_enabled(data_t *data)<br>
> FILE *file;<br>
> char str[4];<br>
><br>
> + if (data->running_with_psr_disabled)<br>
> + return true;<br>
> +<br>
> file = igt_debugfs_fopen("i915_edp_psr_status", "r");<br>
> igt_require(file);<br>
><br>
> @@ -284,6 +288,9 @@ static bool psr_active(data_t *data)<br>
> FILE *file;<br>
> char str[4];<br>
><br>
> + if (data->running_with_psr_disabled)<br>
> + return true;<br>
> +<br>
> file = igt_debugfs_fopen("i915_edp_psr_status", "r");<br>
> igt_require(file);<br>
><br>
> @@ -604,6 +611,7 @@ igt_main<br>
> kmstest_set_vt_graphics_mode();<br>
><br>
> data.devid = intel_get_drm_devid(data.drm_fd);<br>
> + data.running_with_psr_disabled = igt_dry_run;<br>
><br>
> igt_skip_on(!psr_enabled(&data));<br>
><br>
> --<br>
> 1.9.3<br>
><br>
> _______________________________________________<br>
> Intel-gfx mailing list<br>
> <a href="mailto:Intel-gfx@lists.freedesktop.org">Intel-gfx@lists.freedesktop.org</a><br>
> <a href="http://lists.freedesktop.org/mailman/listinfo/intel-gfx" target="_blank">http://lists.freedesktop.org/mailman/listinfo/intel-gfx</a><br>
<br>
</div></div><span class="HOEnZb"><font color="#888888">--<br>
Daniel Vetter<br>
Software Engineer, Intel Corporation<br>
<a href="tel:%2B41%20%280%29%2079%20365%2057%2048" value="+41793655748">+41 (0) 79 365 57 48</a> - <a href="http://blog.ffwll.ch" target="_blank">http://blog.ffwll.ch</a><br>
</font></span><div class="HOEnZb"><div class="h5">_______________________________________________<br>
Intel-gfx mailing list<br>
<a href="mailto:Intel-gfx@lists.freedesktop.org">Intel-gfx@lists.freedesktop.org</a><br>
<a href="http://lists.freedesktop.org/mailman/listinfo/intel-gfx" target="_blank">http://lists.freedesktop.org/mailman/listinfo/intel-gfx</a><br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div>Rodrigo Vivi</div><div>Blog: <a href="http://blog.vivi.eng.br" target="_blank">http://blog.vivi.eng.br</a></div><div> </div>
</div>