<html> <head> <meta content="text/html; charset=ISO-8859-1" http-equiv="Content-Type"> </head> <body text="#000000" bgcolor="#FFFFFF"> <meta http-equiv="Content-Type" content="text/html; charset=ISO-8859-1"> <p class="MsoPlainText">Will the PPGTT fix be sent out soon? If not, can you just send me a quick fix directly?<o:p></o:p></p> <p class="MsoPlainText"><o:p> </o:p></p> <p class="MsoPlainText">Also, noticed that in 'submit_execbuf()', if the 'copy_from_user()' call fails then it jumps to the error return but does not set 'ret' thus will actually return success. Also, there seems to be a mix of 'goto error' vs 'return E*'. In general it looks like you do the goto only after 'rq' has been allocated but there are a couple of places that do the jump with a null 'rq'. The code will cope with trying to put a null rq but it seems a bit inconsistent.<o:p></o:p></p> <p class="MsoPlainText"><o:p> </o:p></p> <br> Thanks,<br> John.<br> <br> <meta name="ProgId" content="Word.Document"> <meta name="Generator" content="Microsoft Word 14"> <meta name="Originator" content="Microsoft Word 14"> <link rel="File-List" href="file:///C:%5CTemp%5Cmsohtmlclip1%5C01%5Cclip_filelist.xml">  <link rel="themeData" href="file:///C:%5CTemp%5Cmsohtmlclip1%5C01%5Cclip_themedata.thmx"> <link rel="colorSchemeMapping" href="file:///C:%5CTemp%5Cmsohtmlclip1%5C01%5Cclip_colorschememapping.xml">  <style>  </style> <div class="moz-cite-prefix">On 11/09/2014 07:51, Chris Wilson wrote:<br> </div> <blockquote cite="mid:20140911065108.GC28332@nuc-i3427.alporthouse.com" type="cite"> <pre wrap="">On Tue, Sep 09, 2014 at 03:14:29PM +0100, John Harrison wrote: </pre> <blockquote type="cite"> <pre wrap="">I pulled a fresh tree on Monday and applied this set of patches. There were two conflicts. It looks like nightly does not have 'i915_gem_context_setparam_ioctl' yet but the tree the patches came from does. Also, my tree has 'DRM_I915_CTX_BAN_PERIOD' instead of 'ctx->hang_stats.ban_period_seconds'. </pre> </blockquote> <pre wrap=""> A couple of patches earlier in the week with which I have been using for stress testing the hangcheck and capture paths. </pre> <blockquote type="cite"> <pre wrap="">However, I can only boot if I have both execlists and PPGTT disabled. With just PPGTT enabled, I get continuous GPU hangs and nothing ever gets rendered. With execlists enabled, I get a null pointer dereference in 'execlists_get_ring'. With both disabled, I can boot to an Ubuntu desktop but shortly after it goes pop with 'BUG_ON(obj->active == 0)' in 'i915_gem_object_retire__read'. </pre> </blockquote> <pre wrap=""> Fixed full-ppgtt, rather trivial oversight. But for lack of hardware and simulator, I haven't been able to run on bdw, so execlists is only compile tested. -Chris </pre> </blockquote> <br> </body> </html>