<div dir="ltr">This is wrong.<div><br></div><div>A skl_enable_backlight must be created setting c8254 propperly without the shift 16. Also maybe setting c8354h.</div><div><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Sep 4, 2014 at 4:26 AM, Damien Lespiau <span dir="ltr"><<a href="mailto:damien.lespiau@intel.com" target="_blank">damien.lespiau@intel.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">From: Satheeshakrishna M <<a href="mailto:satheeshakrishna.m@intel.com">satheeshakrishna.m@intel.com</a>><br>
<br>
Extending the BDW backlight implementation to SKL.<br>
<br>
Signed-off-by: Satheeshakrishna M <<a href="mailto:satheeshakrishna.m@intel.com">satheeshakrishna.m@intel.com</a>><br>
Signed-off-by: Damien Lespiau <<a href="mailto:damien.lespiau@intel.com">damien.lespiau@intel.com</a>><br>
---<br>
 drivers/gpu/drm/i915/intel_panel.c | 2 +-<br>
 1 file changed, 1 insertion(+), 1 deletion(-)<br>
<br>
diff --git a/drivers/gpu/drm/i915/intel_panel.c b/drivers/gpu/drm/i915/intel_panel.c<br>
index 1878447..d69a3cb6 100644<br>
--- a/drivers/gpu/drm/i915/intel_panel.c<br>
+++ b/drivers/gpu/drm/i915/intel_panel.c<br>
@@ -1317,7 +1317,7 @@ void intel_panel_init_backlight_funcs(struct drm_device *dev)<br>
 {<br>
        struct drm_i915_private *dev_priv = dev->dev_private;<br>
<br>
-       if (IS_BROADWELL(dev)) {<br>
+       if (IS_BROADWELL(dev) || (INTEL_INFO(dev)->gen >= 9)) {<br>
                dev_priv->display.setup_backlight = bdw_setup_backlight;<br>
                dev_priv->display.enable_backlight = bdw_enable_backlight;<br>
                dev_priv->display.disable_backlight = pch_disable_backlight;<br>
<span class="HOEnZb"><font color="#888888">--<br>
1.8.3.1<br>
<br>
_______________________________________________<br>
Intel-gfx mailing list<br>
<a href="mailto:Intel-gfx@lists.freedesktop.org">Intel-gfx@lists.freedesktop.org</a><br>
<a href="http://lists.freedesktop.org/mailman/listinfo/intel-gfx" target="_blank">http://lists.freedesktop.org/mailman/listinfo/intel-gfx</a><br>
</font></span></blockquote></div><br><br clear="all"><div><br></div>-- <br><div>Rodrigo Vivi</div><div>Blog: <a href="http://blog.vivi.eng.br" target="_blank">http://blog.vivi.eng.br</a></div><div> </div>
</div>