<div dir="ltr">Oh! ok, so let's not block the progress<div><br></div><div>Thanks, so feel free to use:<div><br></div><div>Reviewed-by: Rodrigo Vivi <<a href="mailto:rodrigo.vivi@intel.com">rodrigo.vivi@intel.com</a>></div></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Sep 22, 2014 at 6:42 AM, Damien Lespiau <span dir="ltr"><<a href="mailto:damien.lespiau@intel.com" target="_blank">damien.lespiau@intel.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On Wed, Sep 17, 2014 at 03:18:21PM -0700, Rodrigo Vivi wrote:<br>
>    Where can I find these pch device id definitions?<br>
<br>
</span>You'll have to trust Satheesh on that, it's not something we have<br>
documented in the GPU specs.<br>
<span class="HOEnZb"><font color="#888888"><br>
--<br>
Damien<br>
</font></span><div class="HOEnZb"><div class="h5"><br>
>    On Thu, Sep 4, 2014 at 4:26 AM, Damien Lespiau <<a href="mailto:damien.lespiau@intel.com">damien.lespiau@intel.com</a>><br>
>    wrote:<br>
><br>
>      From: Satheeshakrishna M <<a href="mailto:satheeshakrishna.m@intel.com">satheeshakrishna.m@intel.com</a>><br>
><br>
>      This patch implements detection of SPT and SPT-LP PCH devices.<br>
><br>
>      v2: Added HAS_PCH_SPT macro<br>
><br>
>      Signed-off-by: Satheeshakrishna M <<a href="mailto:satheeshakrishna.m@intel.com">satheeshakrishna.m@intel.com</a>><br>
>      Signed-off-by: Damien Lespiau <<a href="mailto:damien.lespiau@intel.com">damien.lespiau@intel.com</a>><br>
>      ---<br>
>       drivers/gpu/drm/i915/i915_drv.c | 10 ++++++++++<br>
>       drivers/gpu/drm/i915/i915_drv.h |  4 ++++<br>
>       2 files changed, 14 insertions(+)<br>
><br>
>      diff --git a/drivers/gpu/drm/i915/i915_drv.c<br>
>      b/drivers/gpu/drm/i915/i915_drv.c<br>
>      index 3d7f823..c6a8a80 100644<br>
>      --- a/drivers/gpu/drm/i915/i915_drv.c<br>
>      +++ b/drivers/gpu/drm/i915/i915_drv.c<br>
>      @@ -475,6 +475,16 @@ void intel_detect_pch(struct drm_device *dev)<br>
>                                      DRM_DEBUG_KMS("Found LynxPoint LP<br>
>      PCH\n");<br>
>                                      WARN_ON(!IS_HASWELL(dev));<br>
>                                      WARN_ON(!IS_ULT(dev));<br>
>      +                       } else if (id == INTEL_PCH_SPT_DEVICE_ID_TYPE) {<br>
>      +                               dev_priv->pch_type = PCH_SPT;<br>
>      +                               DRM_DEBUG_KMS("Found SunrisePoint<br>
>      PCH\n");<br>
>      +                               WARN_ON(!IS_SKYLAKE(dev));<br>
>      +                               WARN_ON(IS_ULT(dev));<br>
>      +                       } else if (id ==<br>
>      INTEL_PCH_SPT_LP_DEVICE_ID_TYPE) {<br>
>      +                               dev_priv->pch_type = PCH_SPT;<br>
>      +                               DRM_DEBUG_KMS("Found SunrisePoint LP<br>
>      PCH\n");<br>
>      +                               WARN_ON(!IS_SKYLAKE(dev));<br>
>      +                               WARN_ON(!IS_ULT(dev));<br>
>                              } else<br>
>                                      continue;<br>
><br>
>      diff --git a/drivers/gpu/drm/i915/i915_drv.h<br>
>      b/drivers/gpu/drm/i915/i915_drv.h<br>
>      index cf4fc86..be82888 100644<br>
>      --- a/drivers/gpu/drm/i915/i915_drv.h<br>
>      +++ b/drivers/gpu/drm/i915/i915_drv.h<br>
>      @@ -699,6 +699,7 @@ enum intel_pch {<br>
>              PCH_IBX,        /* Ibexpeak PCH */<br>
>              PCH_CPT,        /* Cougarpoint PCH */<br>
>              PCH_LPT,        /* Lynxpoint PCH */<br>
>      +       PCH_SPT,        /* Sunrisepoint PCH */<br>
>              PCH_NOP,<br>
>       };<br>
><br>
>      @@ -2184,8 +2185,11 @@ struct drm_i915_cmd_table {<br>
>       #define INTEL_PCH_PPT_DEVICE_ID_TYPE           0x1e00<br>
>       #define INTEL_PCH_LPT_DEVICE_ID_TYPE           0x8c00<br>
>       #define INTEL_PCH_LPT_LP_DEVICE_ID_TYPE                0x9c00<br>
>      +#define INTEL_PCH_SPT_DEVICE_ID_TYPE           0xA100<br>
>      +#define INTEL_PCH_SPT_LP_DEVICE_ID_TYPE                0x9D00<br>
><br>
>       #define INTEL_PCH_TYPE(dev) (to_i915(dev)->pch_type)<br>
>      +#define HAS_PCH_SPT(dev) (INTEL_PCH_TYPE(dev) == PCH_SPT)<br>
>       #define HAS_PCH_LPT(dev) (INTEL_PCH_TYPE(dev) == PCH_LPT)<br>
>       #define HAS_PCH_CPT(dev) (INTEL_PCH_TYPE(dev) == PCH_CPT)<br>
>       #define HAS_PCH_IBX(dev) (INTEL_PCH_TYPE(dev) == PCH_IBX)<br>
>      --<br>
>      1.8.3.1<br>
><br>
>      _______________________________________________<br>
>      Intel-gfx mailing list<br>
>      <a href="mailto:Intel-gfx@lists.freedesktop.org">Intel-gfx@lists.freedesktop.org</a><br>
>      <a href="http://lists.freedesktop.org/mailman/listinfo/intel-gfx" target="_blank">http://lists.freedesktop.org/mailman/listinfo/intel-gfx</a><br>
><br>
>    --<br>
>    Rodrigo Vivi<br>
>    Blog: <a href="http://blog.vivi.eng.br" target="_blank">http://blog.vivi.eng.br</a><br>
><br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div>Rodrigo Vivi</div><div>Blog: <a href="http://blog.vivi.eng.br" target="_blank">http://blog.vivi.eng.br</a></div><div> </div>
</div>