<html> <head> <meta content="text/html; charset=windows-1252" http-equiv="Content-Type"> </head> <body bgcolor="#FFFFFF" text="#000000"> I have just posted an updated subset of the patch series. Note that one patch has been inserted in the middle and the first one has been dropped. The correct sequence is now: <blockquote><tt>01 drm/i915: Remove redundant parameter to i915_gem_object_wait_rendering__tail()</tt><tt> </tt><tt>02 drm/i915: Ensure OLS & PLR are always in sync</tt><tt> </tt><tt>03 drm/i915: Add reference count to request structure</tt><tt> </tt><tt>04 drm/i915: Add helper functions to aid seqno -> request transition</tt><tt> </tt><tt>05 drm/i915: Replace last_[rwf]_seqno with last_[rwf]_req</tt><tt> </tt><tt>06 drm/i915: Ensure requests stick around during waits</tt><tt> </tt><tt>07 drm/i915: Remove 'outstanding_lazy_seqno'</tt><tt> </tt><tt>08 drm/i915: Make 'i915_gem_check_olr' actually check by request not seqno</tt><tt> </tt><tt> 09 drm/i915: Convert 'last_flip_req' to be a request not a seqno</tt><tt> </tt><tt>10 drm/i915: Convert i915_wait_seqno to i915_wait_request</tt><tt> </tt><tt>11 drm/i915: Convert 'i915_add_request' to take a request not a seqno</tt><tt> </tt><tt>12 drm/i915: Convert mmio_flip::seqno to struct request</tt><tt> </tt><tt> 13 drm/i915: Convert 'flip_queued_seqno' into 'flip_queued_request'</tt><tt> </tt><tt> 14 drm/i915: Connect requests to rings at creation not submission</tt><tt> </tt><tt> 15 drm/i915: Convert most 'i915_seqno_passed' calls into 'i915_gem_request_completed'</tt><tt> </tt><tt> 16 drm/i915: Convert __wait_seqno() to __wait_request()</tt><tt> </tt><tt> 17 drm/i915: Convert trace functions from seqno to request</tt><tt> </tt><tt> 18 drm/i915: Convert 'trace_irq' to use requests rather than seqnos</tt><tt> </tt><tt> 19 drm/i915: Convert semaphores to handle requests not seqnos</tt><tt> </tt><tt> 20 drm/i915: Convert 'ring_idle()' to use requests not seqnos</tt><tt> </tt><tt> 21 drm/i915: Remove 'obj->ring'</tt><tt> </tt><tt> 22 drm/i915: Cache request completion status</tt><tt> </tt><tt>23 drm/i915: Zero fill the request structure</tt><tt> </tt><tt> 24 drm/i915: Defer seqno allocation until actual hardware submission time</tt> </blockquote> The whole set in its latest and greatest form has also been uploaded to the drm-private git as 'topic/seqno-request'. <div class="moz-cite-prefix">On 06/10/2014 15:15, <a class="moz-txt-link-abbreviated" href="mailto:John.C.Harrison@Intel.com">John.C.Harrison@Intel.com</a> wrote: </div> <blockquote cite="mid:1412604925-11290-1-git-send-email-John.C.Harrison@Intel.com" type="cite"> <pre wrap="">From: John Harrison <a class="moz-txt-link-rfc2396E" href="mailto:John.C.Harrison@Intel.com"><John.C.Harrison@Intel.com></a> Work in progress for replacing seqno usage with requst structures. There is a general feeling that it is better to move away from using a simple integer 'seqno' value to track batch buffer completion. Instead, the request structure should be used. That provides for much more flexibility going forwards. Especially which things like a GPU scheduler (which can re-order batch buffers and hence seqnos after submission to the hardware), Android sync points and other such features which potentially make seqno usage more and more complex. The current set of patches do most of the seqno to request structure conversion. There are still a couple of direct seqno comparisons in the semaphore code. The final conversion of a seqno test into a 'completed' flag inside the request structure is still do to as well. Along with whatever changes are required to maintain such a flag. The patches are being posted now to make sure that the various people involved agree that it is heading in the right direction. [Patches against drm-intel-nightly tree fetched 11/09/2014] John Harrison (21): Bug: missing i915_seqno_passed() call? drm/i915: Remove redundant parameter to i915_gem_object_wait_rendering__tail() drm/i915: Ensure OLS & PLR are always in sync drm/i915: Add reference count to request structure drm/i915: Add helper functions to aid seqno -> request transition drm/i915: Replace last_[rwf]_seqno with last_[rwf]_req drm/i915: Ensure requests stick around during waits drm/i915: Remove 'outstanding_lazy_seqno' drm/i915: Make 'i915_gem_check_olr' actually check by request not seqno drm/i915: Convert 'last_flip_req' to be a request not a seqno drm/i915: Convert i915_wait_seqno to i915_wait_request drm/i915: Convert 'i915_add_request' to take a request not a seqno drm/i915: Convert mmio_flip::seqno to struct request drm/i915: Convert 'flip_queued_seqno' into 'flip_queued_request' drm/i915: Convert most 'i915_seqno_passed' calls into 'i915_gem_request_completed' drm/i915: Convert __wait_seqno() to __wait_request() drm/i915: Convert trace functions from seqno to request drm/i915: Convert 'trace_irq' to use requests rather than seqnos drm/i915: Convert semaphores to handle requests not seqnos drm/i915: Convert 'ring_idle()' to use requests not seqnos drm/i915: Remove 'obj->ring' drivers/gpu/drm/i915/i915_debugfs.c | 23 +-- drivers/gpu/drm/i915/i915_drv.h | 64 +++++-- drivers/gpu/drm/i915/i915_gem.c | 265 ++++++++++++++-------------- drivers/gpu/drm/i915/i915_gem_context.c | 12 +- drivers/gpu/drm/i915/i915_gem_execbuffer.c | 8 +- drivers/gpu/drm/i915/i915_gem_gtt.h | 4 +- drivers/gpu/drm/i915/i915_gem_tiling.c | 2 +- drivers/gpu/drm/i915/i915_gpu_error.c | 19 +- drivers/gpu/drm/i915/i915_irq.c | 12 +- drivers/gpu/drm/i915/i915_trace.h | 47 ++--- drivers/gpu/drm/i915/intel_display.c | 47 ++--- drivers/gpu/drm/i915/intel_drv.h | 4 +- drivers/gpu/drm/i915/intel_lrc.c | 49 ++--- drivers/gpu/drm/i915/intel_overlay.c | 17 +- drivers/gpu/drm/i915/intel_ringbuffer.c | 88 +++++---- drivers/gpu/drm/i915/intel_ringbuffer.h | 24 ++- 16 files changed, 392 insertions(+), 293 deletions(-) </pre> </blockquote> </body> </html>